Bugzilla – Attachment 47149 Details for
Bug 12045
Transfer impossible if barcode includes spaces
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 12045 - Transfer impossible if barcode includes spaces
Bug-12045---Transfer-impossible-if-barcode-include.patch (text/plain), 1.15 KB, created by
Chloe Alabaster
on 2016-01-21 23:51:09 UTC
(
hide
)
Description:
Bug 12045 - Transfer impossible if barcode includes spaces
Filename:
MIME Type:
Creator:
Chloe Alabaster
Created:
2016-01-21 23:51:09 UTC
Size:
1.15 KB
patch
obsolete
>From 87fcbddcf2c3d42f949bc0d99599ba1c7794bdc2 Mon Sep 17 00:00:00 2001 >From: Chloe <chloealabaster@gmail.com> >Date: Thu, 21 Jan 2016 23:47:42 +0000 >Subject: [PATCH] Bug 12045 - Transfer impossible if barcode includes spaces > >have changed the code which strips the white space to only remove the leading and trailing white space instead > >To Test- >1- go to circulation -> transfer >2- attempt to tranfer an item where the barcode has a space in the middle of it >3- it should fail >4- apply patch >5- try again >6- it should work >--- > circ/branchtransfers.pl | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/circ/branchtransfers.pl b/circ/branchtransfers.pl >index 454fbef..a826289 100755 >--- a/circ/branchtransfers.pl >+++ b/circ/branchtransfers.pl >@@ -108,8 +108,8 @@ elsif ( $request eq 'KillReserved' ) { > my @trsfitemloop; > my $transfered; > my $barcode = $query->param('barcode'); >-# strip whitespace >-defined $barcode and $barcode =~ s/\s*//g; # FIXME: barcodeInputFilter >+# remove leading/trailing whitespace >+defined $barcode and $barcode =~ s/^\s*|\s*$//g; # FIXME: barcodeInputFilter > # warn "barcode : $barcode"; > if ($barcode) { > >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 12045
:
47149
|
47182
|
47195