Bugzilla – Attachment 47222 Details for
Bug 15646
koha qa test tools / Test compliance with perlcriticrc
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Allow print function return value to be ignored.
file_15646.txt (text/plain), 784 bytes, created by
Mark Tompsett
on 2016-01-22 20:52:27 UTC
(
hide
)
Description:
Allow print function return value to be ignored.
Filename:
MIME Type:
Creator:
Mark Tompsett
Created:
2016-01-22 20:52:27 UTC
Size:
784 bytes
patch
obsolete
>From 5d7f0cc6b7ac2c737a34a3f835ceeba0598d5a7d Mon Sep 17 00:00:00 2001 >From: Mark Tompsett <mtompset@hotmail.com> >Date: Thu, 21 Jan 2016 10:15:23 -0500 >Subject: [PATCH] Bug 15646: Make perlcritic ignore print return codes. > >If we ever want to get to perlcritic level 1, it doesn't make >sense to require: my $ignore = print "Hello World!\n"; > >This patch ignores the return value for the print function. >--- > perlcriticrc | 3 +++ > 1 file changed, 3 insertions(+) > >diff --git a/perlcriticrc b/perlcriticrc >index d7e5e42..eb4e4ea 100644 >--- a/perlcriticrc >+++ b/perlcriticrc >@@ -14,3 +14,6 @@ equivalent_modules = Modern::Perl > > [-Modules::RequireBarewordIncludes] > >+[InputOutput::RequireCheckedSyscalls] >+functions = :builtins >+exclude_functions = print >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 15646
: 47222