Bugzilla – Attachment 47315 Details for
Bug 15675
Add issue_id column to accountlines and use it for updating fines
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 15675 - Fix some missed tab characters
Bug-15675---Fix-some-missed-tab-characters.patch (text/plain), 1.28 KB, created by
Kyle M Hall (khall)
on 2016-01-26 17:31:57 UTC
(
hide
)
Description:
Bug 15675 - Fix some missed tab characters
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2016-01-26 17:31:57 UTC
Size:
1.28 KB
patch
obsolete
>From 0ee80307ec3bbd7bbedcf6b9fa9adfb6179bdac4 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Tue, 26 Jan 2016 17:32:35 +0000 >Subject: [PATCH] Bug 15675 - Fix some missed tab characters > >--- > C4/Overdues.pm | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/C4/Overdues.pm b/C4/Overdues.pm >index 2871da0..17107dc 100644 >--- a/C4/Overdues.pm >+++ b/C4/Overdues.pm >@@ -595,10 +595,10 @@ sub UpdateFine { > )->store(); > > # FIXME: BOGUS query cannot ensure uniqueness w/ LIKE %x% !!! >- # LIMIT 1 added to prevent multiple affected lines >+ # LIMIT 1 added to prevent multiple affected lines > # FIXME: accountlines table needs unique key!! Possibly a combo of borrowernumber and accountline. >- # But actually, we should just have a regular autoincrementing PK and forget accountline, >- # including the bogus getnextaccountno function (doesn't prevent conflict on simultaneous ops). >+ # But actually, we should just have a regular autoincrementing PK and forget accountline, >+ # including the bogus getnextaccountno function (doesn't prevent conflict on simultaneous ops). > # FIXME: Why only 2 account types here? > } > } else { >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 15675
:
47313
|
47314
|
47315
|
47316
|
47373
|
47374
|
47375
|
47376
|
47378
|
47379
|
47380
|
47600
|
47601
|
47810
|
48468
|
48469
|
48470
|
48471
|
48472
|
48473