Attachment 47346 Details for Bug 12636 – Bug 12636: Do not display unique patron attributes in the batch patron modification

[patch] Bug 12636: Do not display unique patron attributes in the batch patron modification

Bug-12636-Do-not-display-unique-patron-attributes-.patch (text/plain), 1.51 KB, created by Kyle M Hall (khall) on 2016-01-27 13:39:00 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2016-01-27 13:39:00 UTC

Size: 1.51 KB

patch

obsolete

>From d7ae9611914832954322118e2748f9c0b25728d3 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Mon, 21 Dec 2015 12:31:59 +0000
>Subject: [PATCH] Bug 12636: Do not display unique patron attributes in the
> batch patron modification
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>Batch patron modification should not offer to update patron attributes
>with values which are designated as unique since such attributes are
>required to be unique to a single patron.
>
>Test plan:
>Create some patron attributes, some should be unique.
>Use the batch patron modification tool to modify patrons.
>With this patch, the patron attributes marked as unique won't be
>display anymore.
>
>Signed-off-by: Marc VÃ©ron <veron@veron.ch>
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> tools/modborrowers.pl | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/tools/modborrowers.pl b/tools/modborrowers.pl
>index 95d26de..9937993 100755
>--- a/tools/modborrowers.pl
>+++ b/tools/modborrowers.pl
>@@ -110,6 +110,7 @@ if ( $op eq 'show' ) {
>         # TODO Repeatable attributes are not correctly managed and can cause data lost.
>         # This should be implemented.
>         next if $attr_type->{repeatable};
>+        next if $attr_type->{unique_id}; # Don't display patron attributes that must be unqiue
>         my $options = $attr_type->authorised_value_category
>             ? GetAuthorisedValues( $attr_type->authorised_value_category )
>             : undef;
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 12636: 45881 | 45911 | 46373 | 47346