Attachment 47347 Details for Bug 15652 – Bug 15652: Allow current date in datepicker on opac-reserve

[patch] Bug 15652: Allow current date in datepicker on opac-reserve

Bug-15652-Allow-current-date-in-datepicker-on-opac.patch (text/plain), 2.43 KB, created by Jonathan Druart on 2016-01-27 14:09:18 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2016-01-27 14:09:18 UTC

Size: 2.43 KB

patch

obsolete

>From 2fb7df7cee0ed2066d020ef7c2fba12dadbd8f53 Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Mon, 25 Jan 2016 13:14:56 +0100
>Subject: [PATCH] Bug 15652: Allow current date in datepicker on opac-reserve
>
>If you enable AllowHoldDateInFuture (and its OPAC variant), you get
>an additional "Hold starts on date". In that field and in "Hold not
>needed after" it was not possible to enter the current date.
>
>Although it does not really make any difference if you leave the startdate
>empty or put the current date in it, we concluded that it still makes
>a psychological difference. Some patrons were confused when placing a
>hold because the first date to select was tomorrow. Instead of telling
>them "Yes, but you can leave it empty", we should just allow the current
>date as well.
>
>The expiration date ("not needed after") also started on tomorrow. (This
>field can really be empty.) But there is actually no reason not to allow
>today here too. If the patron only wants it today, why force tomorrow?
>
>How is this arranged? Well, this is one of the simplest Koha patches ever
>written. It only changes the minDate option of both date pickers in one
>line from 1 to 0.
>
>Test plan:
>[1] Allow future hold dates via systempreferences.
>[2] Verify that you can enter today in both fields.
>[3] Put today in start and expiration date. Place the hold and verify that
>    you can confirm the hold, check out and check in again.
>
>Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
>Works as advertised
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt
>index de7e3e8..516ada5 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt
>@@ -626,7 +626,7 @@
>             [% IF ( bibitemloo.holdable ) %]
>                 // http://jqueryui.com/demos/datepicker/#date-range
>                 var dates[% bibitemloo.biblionumber %] = $( "#from[% bibitemloo.biblionumber %], #to[% bibitemloo.biblionumber %]" ).datepicker({
>-                    minDate: 1,
>+                    minDate: 0,
>                     changeMonth: true,
>                     numberOfMonths: 1,
>                     onSelect: function( selectedDate ) {
>-- 
>2.1.0

Actions: View | Diff | Splinter Review

Attachments on bug 15652: 47251 | 47262 | 47347