Attachment 47380 Details for Bug 15675 – Bug 15675 - Fix some missed tab characters, remove old FIXMEs

[patch] Bug 15675 - Fix some missed tab characters, remove old FIXMEs

Bug-15675---Fix-some-missed-tab-characters-remove-.patch (text/plain), 2.18 KB, created by Mirko Tietgen on 2016-01-28 10:41:24 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Mirko Tietgen

Created: 2016-01-28 10:41:24 UTC

Size: 2.18 KB

patch

obsolete

>From db607f648f3a6829632733d434ec7c2a6a5ef3a7 Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Tue, 26 Jan 2016 17:32:35 +0000
>Subject: [PATCH] Bug 15675 - Fix some missed tab characters, remove old FIXMEs
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>Signed-off-by: Marc VÃ©ron <veron@veron.ch>
>Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
>---
> C4/Overdues.pm | 25 +++++++++----------------
> 1 file changed, 9 insertions(+), 16 deletions(-)
>
>diff --git a/C4/Overdues.pm b/C4/Overdues.pm
>index 2871da0..e376798 100644
>--- a/C4/Overdues.pm
>+++ b/C4/Overdues.pm
>@@ -529,15 +529,15 @@ sub UpdateFine {
>     # account type has one of several values, but what does this _mean_?
>     # Does it look up existing fines for this item?
>     # FIXME - What are these various account types? ("FU", "O", "F", "M")
>-	#	"L"   is LOST item
>-	#   "A"   is Account Management Fee
>-	#   "N"   is New Card
>-	#   "M"   is Sundry
>-	#   "O"   is Overdue ??
>-	#   "F"   is Fine ??
>-	#   "FU"  is Fine UPDATE??
>-	#	"Pay" is Payment
>-	#   "REF" is Cash Refund
>+    #   "L"   is LOST item
>+    #   "A"   is Account Management Fee
>+    #   "N"   is New Card
>+    #   "M"   is Sundry
>+    #   "O"   is Overdue ??
>+    #   "F"   is Fine ??
>+    #   "FU"  is Fine UPDATE??
>+    #   "Pay" is Payment
>+    #   "REF" is Cash Refund
>     my $sth = $dbh->prepare(
>         "SELECT * FROM accountlines
>         WHERE borrowernumber=?
>@@ -593,13 +593,6 @@ sub UpdateFine {
>                     accounttype   => 'FU',
>                 }
>             )->store();
>-
>-            # FIXME: BOGUS query cannot ensure uniqueness w/ LIKE %x% !!!
>-            # 		LIMIT 1 added to prevent multiple affected lines
>-            # FIXME: accountlines table needs unique key!! Possibly a combo of borrowernumber and accountline.
>-            # 		But actually, we should just have a regular autoincrementing PK and forget accountline,
>-            # 		including the bogus getnextaccountno function (doesn't prevent conflict on simultaneous ops).
>-            # FIXME: Why only 2 account types here?
>         }
>     } else {
>         if ( $amount ) { # Don't add new fines with an amount of 0
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 15675: 47313 | 47314 | 47315 | 47316 | 47373 | 47374 | 47375 | 47376 | 47378 | 47379 | 47380 | 47600 | 47601 | 47810 | 48468 | 48469 | 48470 | 48471 | 48472 | 48473