Bugzilla – Attachment 47456 Details for
Bug 15643
Every datepicker on serials expected date column updates top issue
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 15643 - Every datepicker on serials expected date column updates top issue
Bug-15643---Every-datepicker-on-serials-expected-d.patch (text/plain), 4.43 KB, created by
Jonathan Druart
on 2016-01-29 11:24:42 UTC
(
hide
)
Description:
Bug 15643 - Every datepicker on serials expected date column updates top issue
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2016-01-29 11:24:42 UTC
Size:
4.43 KB
patch
obsolete
>From 41743bb832f69f91291ff97ed223bb55f466b947 Mon Sep 17 00:00:00 2001 >From: Lyon3 Team <koha@univ-lyon3.fr> >Date: Tue, 26 Jan 2016 12:40:11 +0100 >Subject: [PATCH] Bug 15643 - Every datepicker on serials expected date column > updates top issue >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >delete 'expected' and 'supexpected' ids that don't seem useful anymore. >Same thing for changeDate2 function > >Test plan : >1) Search a serial subscription from the Serials Home page >2)Go to serial collection page and make sure it has a mimimal bunch of >already received or missing issues >3)Check some received issues to be sure to get extra issues (not only >the extected one) in the serial edition page >4) Click on Edit serials button >5) Try to modify whatever date in 'Expected on' column (excepted first >one) using datepicker : >You can see that the top date of the column is updated instead of the >choosen one. >6) Apply patch and redo 1 to 5 steps : >now the right date is updated. > >Followed test plan, works as expected. >Signed-off-by: Marc Véron <veron@veron.ch> > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > .../intranet-tmpl/prog/en/modules/serials/serials-edit.tt | 12 ++++-------- > 1 file changed, 4 insertions(+), 8 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt >index 8a4081a..23f0bdc 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt >@@ -41,11 +41,7 @@ function setStatus(serialid){ > $("#status"+serialid).val("2").attr("selected","selected"); > } > function changeDate(elem, adate) { >- $(elem).closest('tr').find('#expecteddate').val(adate); >-} >-function changeDate2(adate) { >- var elem = document.getElementById("supexpecteddate"); >- elem.value = adate; >+ $(elem).closest('tr').find('[name=planneddate]').val(adate); > } > > $(document).ready(function() { >@@ -139,7 +135,7 @@ $(document).ready(function() { > <input type="text" name="publisheddatetext" value="[% serialslis.publisheddatetext %]" size="10" maxlength="100" /> > </td> > <td> >- <input type="text" id="expecteddate" name="planneddate" value="[% serialslis.planneddate %]" size="10" maxlength="15" class="datepicker" /> >+ <input type="text" name="planneddate" value="[% serialslis.planneddate %]" size="10" maxlength="15" class="datepicker" /> > </td> > <td> > [% IF ( serialslis.editdisable ) %] >@@ -296,10 +292,10 @@ $(document).ready(function() { > <input type="text" name="publisheddatetext" value="[% newserialloo.publisheddatetext %]" size="10" maxlength="100" /> > </td> > <td> >- <input type="text" name="planneddate" id="supexpecteddate" value="[% newserialloo.planneddate %]" size="10" maxlength="15" class="datepicker" /> >+ <input type="text" name="planneddate" value="[% newserialloo.planneddate %]" size="10" maxlength="15" class="datepicker" /> > </td> > <td> >- <select name="status" size="1" id="addstatus[% newserialloo.serialid %]" onchange="if (this.value==2){unHideItems('items'+'[% newserialloo.subscriptionid %][% newserialloo.serialid %]','label[% newserialloo.subscriptionid %][% newserialloo.serialid %]','[% newserialloo.serialid %]'); changeDate2('[% newserialloo.arriveddate %]')} else if (this.value==7){changeDate('[% newserialloo.arriveddate %]')} else { HideItems('items'+'[% newserialloo.subscriptionid %]'+[% newserialloo.serialid %],'label[% serialslis.subscriptionid %][% serialslis.serialid %]'); changeDate2('[% serialslis.planneddate %]')}" > >+ <select name="status" size="1" id="addstatus[% newserialloo.serialid %]" onchange="if (this.value==2){unHideItems('items'+'[% newserialloo.subscriptionid %][% newserialloo.serialid %]','label[% newserialloo.subscriptionid %][% newserialloo.serialid %]','[% newserialloo.serialid %]'); changeDate(this, '[% newserialloo.arriveddate %]')} else if (this.value==7){changeDate(this, '[% newserialloo.arriveddate %]')} else { HideItems('items'+'[% newserialloo.subscriptionid %]'+[% newserialloo.serialid %],'label[% serialslis.subscriptionid %][% serialslis.serialid %]'); changeDate(this, '[% serialslis.planneddate %]')}" > > > <option value="">----</option> > [% IF ( newserialloo.status1 ) %] >-- >2.1.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 15643
:
47162
|
47302
|
47371
| 47456