Bugzilla – Attachment 47467 Details for
Bug 15691
Show card number minimum and maximum in visible hint when adding a patron
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 15691: Show card number minimum and maximum in visible hint when adding a patron
Bug-15691-Show-card-number-minimum-and-maximum-in-.patch (text/plain), 4.02 KB, created by
Kyle M Hall (khall)
on 2016-01-29 16:47:33 UTC
(
hide
)
Description:
Bug 15691: Show card number minimum and maximum in visible hint when adding a patron
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2016-01-29 16:47:33 UTC
Size:
4.02 KB
patch
obsolete
>From 2b698d7d90a281231c6916da4bcd3df45799f480 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Thu, 28 Jan 2016 08:54:56 -0500 >Subject: [PATCH] Bug 15691: Show card number minimum and maximum in visible > hint when adding a patron > >The CardnumberLength system preference defines card number minimum and >maximum allowed values when adding a patron. This information is >currently hidden in a title attribute on the card number input field. > >This patch moves the information into a <div class="hint">, matching >other fields in the entry form which offer details about entry >guidelines. > >To test, apply the patch and open the new patron entry form. Test for >various values of CardnumberLength, and with 'cardnumber' mandatory or >not mandatory as defined in BorrowerMandatoryField. > >Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> >Works as advertised > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > .../prog/en/modules/members/memberentrygen.tt | 17 ++++++++++++----- > 1 file changed, 12 insertions(+), 5 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt >index 8a8d3d4..8433229 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt >@@ -633,15 +633,22 @@ > [% END %] > Card number: </label> > [% IF minlength_cardnumber == maxlength_cardnumber %] >- <input type="text" id="cardnumber" name="cardnumber" size="20" value="[% cardnumber %]" minlength="[% minlength_cardnumber %]" maxlength="[% maxlength_cardnumber %]" title="exactly [% minlength_cardnumber %] characters" /> >+ <input type="text" id="cardnumber" name="cardnumber" size="20" value="[% cardnumber %]" minlength="[% minlength_cardnumber %]" maxlength="[% maxlength_cardnumber %]" /> >+ [% IF ( mandatorycardnumber ) %]<span class="required">Required</span>[% END %] >+ <div class="hint">Card number must be exactly [% minlength_cardnumber %] characters.</div> > [% ELSIF minlength_cardnumber && maxlength_cardnumber %] >- <input type="text" id="cardnumber" name="cardnumber" size="20" value="[% cardnumber %]" minlength="[% minlength_cardnumber %]" maxlength="[% maxlength_cardnumber %]" title="between [% minlength_cardnumber %] and [% maxlength_cardnumber %] characters" /> >+ <input type="text" id="cardnumber" name="cardnumber" size="20" value="[% cardnumber %]" minlength="[% minlength_cardnumber %]" maxlength="[% maxlength_cardnumber %]" /> >+ [% IF ( mandatorycardnumber ) %]<span class="required">Required</span>[% END %] >+ <div class="hint">Card number must be between [% minlength_cardnumber %] and [% maxlength_cardnumber %] characters.</div> > [% ELSIF maxlength_cardnumber %] >- <input type="text" id="cardnumber" name="cardnumber" size="20" value="[% cardnumber %]" maxlength="[% maxlength_cardnumber %]" title="up to [% maxlength_cardnumber %] characters" /> >+ <input type="text" id="cardnumber" name="cardnumber" size="20" value="[% cardnumber %]" maxlength="[% maxlength_cardnumber %]" /> >+ [% IF ( mandatorycardnumber ) %]<span class="required">Required</span>[% END %] >+ <div class="hint">Card number can be up to [% maxlength_cardnumber %] characters.</div> > [% ELSE %] >- <input type="text" id="cardnumber" name="cardnumber" size="20" value="[% cardnumber %]" /> >+ <input type="text" id="cardnumber" name="cardnumber" size="20" value="[% cardnumber %]" /> >+ [% IF ( mandatorycardnumber ) %]<span class="required">Required</span>[% END %] >+ <div class="hint">There is no minimum or maximum character length.</div> > [% END %] >- [% IF ( mandatorycardnumber ) %]<span class="required">Required</span>[% END %] > </li> > [% END %] > [% UNLESS nobranchcode %] >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 15691
:
47389
|
47390
| 47467