Attachment 47473 Details for Bug 15631 – Bug 15631: Koha::Cities - remove getzipnamecity

[patch] Bug 15631: Koha::Cities - remove getzipnamecity

Bug-15631-KohaCities---remove-getzipnamecity.patch (text/plain), 1.43 KB, created by Kyle M Hall (khall) on 2016-01-29 17:52:28 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2016-01-29 17:52:28 UTC

Size: 1.43 KB

patch

obsolete

>From 67623cd67827b59cb164a8087d1e93c892c9b4fe Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Wed, 20 Jan 2016 14:59:48 +0000
>Subject: [PATCH] Bug 15631: Koha::Cities - remove getzipnamecity
>
>C4::Members::getzipnamecity was not used and can be remove safely.
>
>Test plan:
>  git grep getzipnamecity
>should not return any result.
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> C4/Members.pm | 20 --------------------
> 1 file changed, 20 deletions(-)
>
>diff --git a/C4/Members.pm b/C4/Members.pm
>index 4ba1f19..4eaea62 100644
>--- a/C4/Members.pm
>+++ b/C4/Members.pm
>@@ -66,7 +66,6 @@ BEGIN {
>         &GetPendingIssues
>         &GetAllIssues
> 
>-        &getzipnamecity
>         &getidcity
> 
>         &GetFirstValidEmailAddress
>@@ -1357,25 +1356,6 @@ sub get_cardnumber_length {
>     return ( $min, $max );
> }
> 
>-=head2 getzipnamecity (OUEST-PROVENCE)
>-
>-take all info from table city for the fields city and  zip
>-check for the name and the zip code of the city selected
>-
>-=cut
>-
>-sub getzipnamecity {
>-    my ($cityid) = @_;
>-    my $dbh      = C4::Context->dbh;
>-    my $sth      =
>-      $dbh->prepare(
>-        "select city_name,city_state,city_zipcode,city_country from cities where cityid=? ");
>-    $sth->execute($cityid);
>-    my @data = $sth->fetchrow;
>-    return $data[0], $data[1], $data[2], $data[3];
>-}
>-
>-
> =head2 getdcity (OUEST-PROVENCE)
> 
> recover cityid  with city_name condition
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 15631: 47010 | 47011 | 47062 | 47473 | 47474