Attachment 47548 Details for Bug 15713 – Bug 15713: Restart zebra when rotating logfiles

[patch] Bug 15713: Restart zebra when rotating logfiles

Bug-15713-Restart-zebra-when-rotating-logfiles.patch (text/plain), 2.01 KB, created by Jonathan Druart on 2016-02-02 11:49:12 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2016-02-02 11:49:12 UTC

Size: 2.01 KB

patch

obsolete

>From f487a1ccf454863b27848fe4179881cc4cd50e50 Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Mon, 1 Feb 2016 13:48:06 +0100
>Subject: [PATCH] Bug 15713: Restart zebra when rotating logfiles
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>Somehow, it may happen that Zebra keeps writing to the old rotated logfile
>with extension .log.1. I must add that although I saw that happen (a new
>log was created and was empty, while Zebra kept writing to log.1 for weeks),
>I cannot reproduce it every time.
>
>By stopping the zebra server in prerotate and starting it again in
>postrotate, this should not happen at all. In practice, this implies that
>your Zebra server is restarted once a week.
>
>Note: The existing sharedscripts directive makes sure that these actions
>are not executed for all individual logfiles but once for all matching
>logfiles (even when running multiple instances).
>
>Test plan:
>[1] Apply the change in koha-common.logrotate to the file
>    /etc/logrotate.d/koha-common.
>[2] Run logrotate -f /etc/logrotate.conf (forcing a logrotate).
>[3] Check in zebra-error.log that your zebra server was stopped
>    ('killed by signal 15').
>[4] Verify that your Zebra server runs (read: has been restarted).
>    (Do a search..)
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Signed-off-by: Marc VÃ©ron <veron@veron.ch>
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> debian/koha-common.logrotate | 4 ++++
> 1 file changed, 4 insertions(+)
>
>diff --git a/debian/koha-common.logrotate b/debian/koha-common.logrotate
>index 37024d3..0299b62 100644
>--- a/debian/koha-common.logrotate
>+++ b/debian/koha-common.logrotate
>@@ -8,7 +8,11 @@
>     delaycompress
>     notifempty
>     sharedscripts
>+    prerotate
>+        /usr/sbin/koha-stop-zebra $(koha-list --enabled) > /dev/null
>+    endscript
>     postrotate
>         /etc/init.d/apache2 reload > /dev/null
>+        /usr/sbin/koha-start-zebra $(koha-list --enabled) > /dev/null
>     endscript
> }
>-- 
>2.1.0

Actions: View | Diff | Splinter Review

Attachments on bug 15713: 47504 | 47535 | 47548