Attachment 47549 Details for Bug 13302 – Bug 13302 [Revised] Use CSS3 ellipsis for email address in staff client patron sidebar

[patch] Bug 13302 [Revised] Use CSS3 ellipsis for email address in staff client patron sidebar

Bug-13302-Revised-Use-CSS3-ellipsis-for-email-addr.patch (text/plain), 5.73 KB, created by Marc Véron on 2016-02-02 12:26:16 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marc Véron

Created: 2016-02-02 12:26:16 UTC

Size: 5.73 KB

patch

obsolete

>From 4d8bc3372e1b0a8e676f54bd7af6520928dcf7f5 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Wed, 19 Nov 2014 14:31:31 -0500
>Subject: [PATCH] Bug 13302 [Revised] Use CSS3 ellipsis for email address in
> staff client patron sidebar
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>This patch replaces the email address text overflow solution implemented
>by Bug 3256 with a CSS3 technique: text-overflow: ellipsis
>
>https://developer.mozilla.org/en-US/docs/Web/CSS/text-overflow
>
>To test, apply the patch and clear your browser cache. Edit the primary
>email address of a patron so that it is very long. View that patron in
>the staff client (on the checkout or details page, for instance) and
>confirm that the email address is truncated with "..."
>
>Confirm that the link and the title attribute of the link contain the
>correct, full email address.
>
>Revision uses a percentage instead of a fixed width for email display in
>the sidebar to accommodate varying sidebar widths. Also added: Handling
>of all email addresses displayed on the patron detail page. Although
>email addresses in the body of that page were not in the scope of the
>original patch, it's a good improvement to include those as well.
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>
>Signed-off-by: Marc VÃ©ron <veron@veron.ch>
>---
> .../intranet-tmpl/prog/en/css/staff-global.css | 19 +++++++++----------
> .../prog/en/modules/members/moremember.tt | 10 +++++-----
> koha-tmpl/intranet-tmpl/prog/img/elipsis.gif | Bin 51 -> 0 bytes
> 3 files changed, 14 insertions(+), 15 deletions(-)
> delete mode 100644 koha-tmpl/intranet-tmpl/prog/img/elipsis.gif
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css b/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css
>index b35e6be..669aa62 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css
>+++ b/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css
>@@ -1406,17 +1406,16 @@ h1#logo a {
> vertical-align: middle;
> }
> 
>-li.email a {
>-	display:block;
>-	overflow:hidden;
>-	width:13em;
>-}
> li.email {
>-	background: #FFF url(../../img/elipsis.gif) right bottom no-repeat;
>-	font-size : 87%;
>-	overflow:hidden;
>-	padding :0 10px 0 0;
>-	width:13em;
>+ overflow: hidden;
>+ text-overflow: ellipsis;
>+ white-space: nowrap;
>+}
>+
>+.patronbriefinfo li.email {
>+ font-size : 87%;
>+ padding : 0 10px 0 0;
>+ width: 90%;
> }
> 
> .empty {
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
>index b1a7bee..e2800d2 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
>@@ -136,7 +136,7 @@ function validate1(date) {
> &rsaquo; [% IF ( unknowuser ) %]Patron does not exist[% ELSE %]Patron details for [% INCLUDE 'patron-title.inc' %][% END %]
> </div>
> 
>-<div id="doc3" class="yui-t1">
>+<div id="doc3" class="yui-t2">
> 
> <div id="bd">
> 	<div id="yui-main">
>@@ -211,7 +211,7 @@ function validate1(date) {
> 		<ol>
> [% IF ( I ) %]
> [% IF ( phonepro ) %]<li>Organization phone: [% phonepro %]</li>[% END %]
>- [% IF ( emailpro ) %]<li>Organization email: [% emailpro %]</li>[% END %]
>+ [% IF ( emailpro ) %]<li class="email">Organization email: [% emailpro %]</li>[% END %]
> [% ELSE %]
> [% IF ( phone ) %]<li>Primary phone: [% phone %]</li>[% END %]
> [% IF ( phonepro ) %]<li>Secondary phone: [% phonepro %]</li>[% END %]
>@@ -224,8 +224,8 @@ function validate1(date) {
> [% END %] 	
> 	[% IF ( fax ) %]<li>Fax: [% fax %]</li>[% END %]
> [% UNLESS ( I ) %]
>- [% IF ( email ) %]<li>Primary email:<a href="mailto:[% email %]">[% email %]</a></li>[% END %]
>- [% IF ( emailpro ) %]<li>Secondary email: <a href="mailto:[% emailpro %]">[% emailpro %]</a></li>[% END %]
>+ [% IF ( email ) %]<li class="email">Primary email:<a title="[% email %]" href="mailto:[% email %]">[% email %]</a></li>[% END %]
>+ [% IF ( emailpro ) %]<li class="email">Secondary email: <a title="[% emailpro %]" href="mailto:[% emailpro %]">[% emailpro %]</a></li>[% END %]
> [% END %]
> [% IF ( initials ) %]<li>Initials: [% initials %]</li>[% END %]
> [% IF ( dateofbirth ) %]<li>Date of birth:[% dateofbirth | $KohaDates %] ([% age %] years)</li>[% END %]
>@@ -403,7 +403,7 @@ function validate1(date) {
> <li>ZIP/Postal code: [% B_zipcode %]</li>
> [% IF ( B_country ) %]<li>Country: [% B_country %]</li>[% END %]
> [% IF ( B_phone ) %]<li>Phone: [% B_phone %]</li>[% END %]
>- [% IF ( B_email ) %]<li>Email: <a href="mailto:[% B_email %]">[% B_email %]</a></li>[% END %]
>+ [% IF ( B_email ) %]<li class="email">Email: <a title="[% B_email %]" href="mailto:[% B_email %]">[% B_email %]</a></li>[% END %]
> [% IF ( contactnote ) %]<li>Contact note: [% contactnote %]</li>[% END %]
> </ol>
> </div>
>diff --git a/koha-tmpl/intranet-tmpl/prog/img/elipsis.gif b/koha-tmpl/intranet-tmpl/prog/img/elipsis.gif
>deleted file mode 100644
>index 15ed1563d711f23e69e669c800a96921a0e0e1d2..0000000000000000000000000000000000000000
>GIT binary patch
>literal 0
>HcmV?d00001
>
>literal 51
>zcmZ?wbhEHb<YeGvXkcVuU^w&t|9{1wEI=kBgAR}n6z61MVB+fOUwQg%Lc)YRQ3h)O
>DKQavY
>
>-- 
>1.7.10.4

Actions: View | Diff | Splinter Review

Attachments on bug 13302: 33693 | 33701 | 47507 | 47549 | 47576