Bugzilla – Attachment 47567 Details for
Bug 15415
Warn when creating new printer profile for patron card creator
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF]Bug 15415: Warn when creating a new print profile
SIGNED-OFFBug-15415-Warn-when-creating-a-new-print.patch (text/plain), 1.29 KB, created by
Héctor Eduardo Castro Avalos
on 2016-02-02 20:59:36 UTC
(
hide
)
Description:
[SIGNED-OFF]Bug 15415: Warn when creating a new print profile
Filename:
MIME Type:
Creator:
Héctor Eduardo Castro Avalos
Created:
2016-02-02 20:59:36 UTC
Size:
1.29 KB
patch
obsolete
>From 8e56143b05c03945c6ffc897b7bc4a0c91972a97 Mon Sep 17 00:00:00 2001 >From: Aleisha <aleishaamohia@hotmail.com> >Date: Mon, 18 Jan 2016 03:24:39 +0000 >Subject: [PATCH] [SIGNED-OFF]Bug 15415: Warn when creating a new print > profile > >This warn is hard-coded in Profile.pm > >sub get_attr { > my $self = shift; > if (_check_params(@_) eq 1) { > return -1; > } > my ($attr) = @_; > if (exists($self->{$attr})) { > return $self->{$attr}; > } > else { > warn sprintf('%s is currently undefined.', $attr); <-- THIS LINE > return -1; > } >} > >So I have removed this line because I don't think it's really necessary. > >To test: >1) Go to Tools -> Patron Card Creator -> New printer profile >2) Notice warn >3) Apply patch >4) Refresh page >5) Confirm warn is gone and page still works as expected > >Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> >Warn is gone and working correctly >--- > C4/Creators/Profile.pm | 1 - > 1 file changed, 1 deletion(-) > >diff --git a/C4/Creators/Profile.pm b/C4/Creators/Profile.pm >index 54151d1..2db833b 100644 >--- a/C4/Creators/Profile.pm >+++ b/C4/Creators/Profile.pm >@@ -184,7 +184,6 @@ sub get_attr { > return $self->{$attr}; > } > else { >- warn sprintf('%s is currently undefined.', $attr); > return -1; > } > } >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 15415
:
46760
|
47567
|
57876
|
58241
|
58316