Attachment 47652 Details for Bug 14930 – 14930 - Leaving OpacFineNoRenewals blank blocks renewals, but should disable feature

[patch] 14930 - Leaving OpacFineNoRenewals blank blocks renewals, but should disable feature

14930---Leaving-OpacFineNoRenewals-blank-blocks-re.patch (text/plain), 1.51 KB, created by Marc Véron on 2016-02-04 19:29:33 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marc Véron

Created: 2016-02-04 19:29:33 UTC

Size: 1.51 KB

patch

obsolete

>From 81e47592ffac47bb490922f6d5c0a59385a77a2d Mon Sep 17 00:00:00 2001
>From: Gus <gel1163@stacmail.net>
>Date: Tue, 19 Jan 2016 03:12:48 +0000
>Subject: [PATCH] 14930 - Leaving OpacFineNoRenewals blank blocks renewals,
> but should disable feature
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>To Test
>- Borrower has some fines and checkouts
>- Leave OPACFineNoRenewals empty/blank
>- Try to renew items in the OPAC
>- notice error message
>- Add a big value to OpacFineNoRenewals
>- notice renewals work
>
>Leaving the OPACFineNoRenewals empty will disable the feature.
>
>Patch works as expected.(Amended to format the commit message and to
>remove a warn on line 112 / MV)
>Signed-off-by: Marc VÃ©ron <veron@veron.ch>
>---
> opac/opac-user.pl |    4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/opac/opac-user.pl b/opac/opac-user.pl
>index 9d1f9b2..e9529b5 100755
>--- a/opac/opac-user.pl
>+++ b/opac/opac-user.pl
>@@ -107,9 +107,9 @@ if ( 5 >= $borr->{'amountoutstanding'} && $borr->{'amountoutstanding'} > 0 ) {
>     $borr->{'amountoverzero'} = 1;
> }
> my $no_renewal_amt = C4::Context->preference( 'OPACFineNoRenewals' );
>-$no_renewal_amt ||= 0;
>+$no_renewal_amt ||= undef;
> 
>-if (  C4::Context->preference( 'OpacRenewalAllowed' ) && $borr->{amountoutstanding} > $no_renewal_amt ) {
>+if (  C4::Context->preference( 'OpacRenewalAllowed' ) && $no_renewal_amt && $borr->{amountoutstanding} > $no_renewal_amt ) {
>     $borr->{'flagged'} = 1;
>     $canrenew = 0;
>     $template->param(
>-- 
>1.7.10.4

Actions: View | Diff | Splinter Review

Attachments on bug 14930: 46845 | 46846 | 47271 | 47466 | 47652 | 47653 | 47792 | 47793