Attachment 47723 Details for Bug 14097 – Bug 14097 : Avoid issue if the number of syspref shared is modified

[patch] Bug 14097 : Avoid issue if the number of syspref shared is modified

Bug-14097--Avoid-issue-if-the-number-of-syspref-sh.patch (text/plain), 1.99 KB, created by Indranil Das Gupta on 2016-02-06 03:43:10 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Indranil Das Gupta

Created: 2016-02-06 03:43:10 UTC

Size: 1.99 KB

patch

obsolete

>From fecfaec718694d5341f53f02e75b1a4e51e67ae1 Mon Sep 17 00:00:00 2001
>From: Julian FIOL <julian.fiol@biblibre.com>
>Date: Mon, 24 Aug 2015 13:50:16 +0200
>Subject: [PATCH] Bug 14097 : Avoid issue if the number of syspref shared is
> modified
>
>Signed-off-by: Indranil Das Gupta (L2C2 Technologies) <indradg@gmail.com>
>---
> t/db_dependent/UsageStats.t | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
>diff --git a/t/db_dependent/UsageStats.t b/t/db_dependent/UsageStats.t
>index ad2dd15..2d92e79 100644
>--- a/t/db_dependent/UsageStats.t
>+++ b/t/db_dependent/UsageStats.t
>@@ -15,7 +15,7 @@
> # with Koha; if not, see <http://www.gnu.org/licenses>.
> 
> use Modern::Perl;
>-use Test::More tests => 551;
>+use Test::More tests => 549;
> use t::lib::Mocks qw(mock_preference);
> use POSIX qw(strftime);
> 
>@@ -150,7 +150,6 @@ mocking_systempreferences_to_a_set_value(0);
> $report = C4::UsageStats->BuildReport();
> isa_ok( $report,                      'HASH', '$report is a HASH' );
> isa_ok( $report->{systempreferences}, 'HASH', '$report->{systempreferences} is a HASH' );
>-is( scalar( keys %{$report->{systempreferences}} ), 248, "There are 248 fields in $report->{systempreferences}" );
> verif_systempreferences_values( $report, 0 );
> 
> #mock with values
>@@ -159,9 +158,12 @@ mocking_systempreferences_to_a_set_value(1);
> $report = C4::UsageStats->BuildReport();
> isa_ok( $report,                      'HASH', '$report is a HASH' );
> isa_ok( $report->{systempreferences}, 'HASH', '$report->{systempreferences} is a HASH' );
>-is( scalar( keys %{$report->{systempreferences}} ), 248, "There are 248 fields in $report->{systempreferences}" );
> verif_systempreferences_values( $report, 1 );
> 
>+#Test if unwanted syspref are not sent
>+is( $report->{systempreferences}->{useDischarge}, undef, 'useDischarge should not be shared');
>+is( $report->{systempreferences}->{OpacUserJS},   undef, 'OpacUserJS   should not be shared');
>+
> # ---------- Testing ReportToCommunity ----------
> 
> # ---------- Testing _count ---------------------
>-- 
>1.9.1

Actions: View | Diff | Splinter Review

Attachments on bug 14097: 38719 | 38800 | 38814 | 38946 | 38947 | 38948 | 39080 | 39085 | 39435 | 41837 | 41843 | 41844 | 46200 | 46201 | 46202 | 46203 | 46204 | 46205 | 46206 | 46207 | 46208 | 46209 | 46210 | 46211 | 46212 | 46213 | 46214 | 46215 | 47717 | 47719 | 47720 | 47721 | 47722 | 47723 | 47724 | 47725 | 47726 | 47727 | 47798 | 47799 | 47800 | 47801 | 47802 | 47803 | 47804 | 47805