Attachment 47737 Details for Bug 15754 – Bug 15754: Fix regression on editing framework subfields

[patch] Bug 15754: Fix regression on editing framework subfields

Bug-15754-Fix-regression-on-editing-framework-subf.patch (text/plain), 3.21 KB, created by Jonathan Druart on 2016-02-08 12:04:01 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2016-02-08 12:04:01 UTC

Size: 3.21 KB

patch

obsolete

>From a53976577cd1789a63faa1c0490a9ff008845448 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Mon, 8 Feb 2016 12:03:01 +0000
>Subject: [PATCH] Bug 15754: Fix regression on editing framework subfields
>
>When editing subfields the "repeatable", "mandatory" and "is url"
>checkboxes are not displayed: the input html tag is displayed instead.
>Caused by bug 13618.
>
>Test plan:
>Edit subfields and confirm the bug.
>Apply the patch and confirm that you are not able to check/uncheck
>checkboxes.
>---
> .../intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tt | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tt
>index ea573d4..ec27b4e 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tt
>@@ -227,8 +227,8 @@ function populateHiddenCheckboxes(tab) {
>                 		[% END %]
>                 		<li><label for="liblibrarian[% loo.row %]">Text for librarian: </label><input id="liblibrarian[% loo.row %]" type="text" name="liblibrarian" value="[% loo.liblibrarian %]" size="40" maxlength="80" /></li>
>                 		<li><label for="libopac[% loo.row %]">Text for OPAC: </label><input type="text" id="libopac[% loo.row %]" name="libopac" value="[% loo.libopac %]" size="40" maxlength="80" /></li>
>-                		<li><label for="repeatable[% loo.row %]">Repeatable: </label>[% loo.repeatable %]</li>
>-                		<li><label for="mandatory[% loo.row %]">Mandatory: </label>[% loo.mandatory %]</li>
>+                        <li><label for="repeatable[% loo.row %]">Repeatable: </label>[% loo.repeatable.raw %]</li>
>+                        <li><label for="mandatory[% loo.row %]">Mandatory: </label>[% loo.mandatory.raw %]</li>
>                         <li><label for="tab[% loo.row %]">Managed in tab: </label>
>                             <select name="tab" tabindex="" size="1" id="[% loo.tab.id %]">
>                             [%- IF ( loo.tab.default ==  -1 ) -%]
>@@ -275,7 +275,7 @@ function populateHiddenCheckboxes(tab) {
>                     <input type="checkbox" id="hidden_flagged_[% loo.row %]" name="flagged_[% loo.row %]"/>
>                     <label for="hidden_flagged_[% loo.row %]" style="float: none;">Flagged</label>
>                 </li>
>-                <li><label for="isurl[% loo.row %]">Is a URL:</label>[% loo.isurl %] (if checked, it means that the subfield is a URL and can be clicked)</li>
>+                <li><label for="isurl[% loo.row %]">Is a URL:</label>[% loo.isurl.raw %] (if checked, it means that the subfield is a URL and can be clicked)</li>
>                 <li><label for="link[% loo.row %]">Link:</label><input type="text" id="link[% loo.row %]" name="link" value="[% loo.link %]" size="10" maxlength="80" /> (e.g., Title or Local-Number) <span class="error"><em>NOTE: If you change this value you must ask your administrator to run misc/batchRebuildBiblioTables.pl.</em></span></li>
>                 <li>
>                     <label for="kohafield[% loo.row %]">Koha link:</label>
>-- 
>2.1.0

Actions: View | Diff | Splinter Review

Attachments on bug 15754: 47737 | 47742 | 47809 | 47823