Attachment 47858 Details for Bug 15784 – Bug 15784 - Library deletion warning is incorrectly styled

[patch] Bug 15784 - Library deletion warning is incorrectly styled

Bug-15784---Library-deletion-warning-is-incorrectl.patch (text/plain), 2.44 KB, created by Owen Leonard on 2016-02-10 16:31:00 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Owen Leonard

Created: 2016-02-10 16:31:00 UTC

Size: 2.44 KB

patch

obsolete

>From d27339fead76f8a79f62b4d47078da2c4e6cfe3e Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Wed, 3 Feb 2016 08:40:20 -0500
>Subject: [PATCH] Bug 15784 - Library deletion warning is incorrectly styled
>Content-Type: text/plain; charset="utf-8"
>
>When deleting a library in Administration ->  Libraries and groups, the
>deletion confirmation message is not styled with the standard "dialog
>alert" <div>. This patch modifies the confirmation markup to match the
>standard.
>
>To test, apply the patch and go to Administration -> Libraries and
>groups.
>
>- Try deleting a library. The confirmation box should have the standard
>  "dialog alert" class.
>- Test the 'confirm' and 'cancel' actions and make sure both complete
>  correctly.
>---
> .../intranet-tmpl/prog/en/modules/admin/branches.tt    | 18 +++++++++---------
> 1 file changed, 9 insertions(+), 9 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt
>index 36c4f2b..de4e4c9 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt
>@@ -202,18 +202,18 @@ tinyMCE.init({
> [% END %]
> 
> [% IF op == 'delete_confirm' and not ( items_count or patrons_count )%]
>-    <form action="/cgi-bin/koha/admin/branches.pl" method="post">
>-        <fieldset>
>-            <legend>Confirm deletion of [% library.branchname %] ([% library.branchcode %])?</legend>
>+    <div class="dialog alert">
>+        <form action="/cgi-bin/koha/admin/branches.pl" method="post">
>+            <h3>Are you sure you want to delete [% library.branchname %] ([% library.branchcode %])?</h3>
>             <input type="hidden" name="op" value="delete_confirmed" />
>             <input type="hidden" name="branchcode" value="[% library.branchcode %]" />
>             <input type="hidden" name="branchname" value="[% library.branchname %]">
>-            <fieldset class="action">
>-                <input type="submit" value="Delete Library" />
>-                <a class="cancel" href="/cgi-bin/koha/admin/branches.pl">Cancel</a>
>-            </fieldset>
>-        </fieldset>
>-    </form>
>+            <input type="submit" class="approve" value="Yes, delete" />
>+        </form>
>+        <form action="/cgi-bin/koha/admin/branches.pl" method="get">
>+            <input type="submit" class="deny" value="No, do not delete" />
>+        </form>
>+    </div>
> [% END %]
> 
> [% IF op == 'list' %]
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 15784: 47858 | 47867 | 47976 | 47977 | 47987 | 47989 | 48734