Bugzilla – Attachment 47867 Details for
Bug 15784
Library deletion warning is incorrectly styled
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF]Bug 15784: Library deletion warning is incorrectly styled
SIGNED-OFFBug-15784-Library-deletion-warning-is-in.patch (text/plain), 2.49 KB, created by
Héctor Eduardo Castro Avalos
on 2016-02-10 19:08:33 UTC
(
hide
)
Description:
[SIGNED-OFF]Bug 15784: Library deletion warning is incorrectly styled
Filename:
MIME Type:
Creator:
Héctor Eduardo Castro Avalos
Created:
2016-02-10 19:08:33 UTC
Size:
2.49 KB
patch
obsolete
>From 54327453b1191d0bea6f422bb8ec8aa318c1b8ac Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Wed, 3 Feb 2016 08:40:20 -0500 >Subject: [PATCH] [SIGNED-OFF]Bug 15784: Library deletion warning is > incorrectly styled > >When deleting a library in Administration -> Libraries and groups, the >deletion confirmation message is not styled with the standard "dialog >alert" <div>. This patch modifies the confirmation markup to match the >standard. > >To test, apply the patch and go to Administration -> Libraries and >groups. > >- Try deleting a library. The confirmation box should have the standard > "dialog alert" class. >- Test the 'confirm' and 'cancel' actions and make sure both complete > correctly. > >Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> >Works as advertised >--- > .../intranet-tmpl/prog/en/modules/admin/branches.tt | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt >index 36c4f2b..de4e4c9 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt >@@ -202,18 +202,18 @@ tinyMCE.init({ > [% END %] > > [% IF op == 'delete_confirm' and not ( items_count or patrons_count )%] >- <form action="/cgi-bin/koha/admin/branches.pl" method="post"> >- <fieldset> >- <legend>Confirm deletion of [% library.branchname %] ([% library.branchcode %])?</legend> >+ <div class="dialog alert"> >+ <form action="/cgi-bin/koha/admin/branches.pl" method="post"> >+ <h3>Are you sure you want to delete [% library.branchname %] ([% library.branchcode %])?</h3> > <input type="hidden" name="op" value="delete_confirmed" /> > <input type="hidden" name="branchcode" value="[% library.branchcode %]" /> > <input type="hidden" name="branchname" value="[% library.branchname %]"> >- <fieldset class="action"> >- <input type="submit" value="Delete Library" /> >- <a class="cancel" href="/cgi-bin/koha/admin/branches.pl">Cancel</a> >- </fieldset> >- </fieldset> >- </form> >+ <input type="submit" class="approve" value="Yes, delete" /> >+ </form> >+ <form action="/cgi-bin/koha/admin/branches.pl" method="get"> >+ <input type="submit" class="deny" value="No, do not delete" /> >+ </form> >+ </div> > [% END %] > > [% IF op == 'list' %] >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 15784
:
47858
|
47867
|
47976
|
47977
|
47987
|
47989
|
48734