Attachment 47949 Details for Bug 15670 – Bug 15670 - Rename "Cancel" to "Cancel hold" when checking in a waiting item

[patch] Bug 15670 - Rename "Cancel" to "Cancel hold" when checking in a waiting item

Bug-15670---Rename-Cancel-to-Cancel-hold-when-chec.patch (text/plain), 2.53 KB, created by Marcel de Rooy on 2016-02-12 07:23:07 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2016-02-12 07:23:07 UTC

Size: 2.53 KB

patch

obsolete

>From 73b58d878f1c473460db12f2d3222db0a6383c00 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Thu, 11 Feb 2016 08:56:42 -0500
>Subject: [PATCH] Bug 15670 - Rename "Cancel" to "Cancel hold" when checking
> in a waiting item
>Content-Type: text/plain; charset=utf-8
>
>When checking in an on-hold item which is waiting, the "Cancel" button
>cancels the hold, so it should say so. This patch changes the text.
>
>This patch also moves the 'cancel hold' button to the middle, on the
>theory that buttons on the left should default to 'confirm' and buttons
>on the right should generally imply 'cancel'--as in 'do nothing.' Moving
>it to the middle seems like a good place to put it where users will have
>to think about clicking it.
>
>To test:
>
>1. Find an hold which has been made 'waiting,' or check in an confirm a
>   pending hold at your library.
>2. Check in that item again and verify that the 'Hold found' dialog
>   contains a 'Cancel hold' button which works to cancel the waiting
>   hold.
>3. Repeat the process and confirm that the functionality of the other
>   buttons is unchanged.
>
>Followed test plan, works as expected.
>Signed-off-by: Marc Veron <veron@veron.ch>
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt |    5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
>index a56b8e6..0e1fe33 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
>@@ -233,11 +233,12 @@ $(document).ready(function () {
> 		<h4><strong>Hold at</strong> [% destbranchname %]</h4>
>         [% END %]
>         <form method="post" action="returns.pl" class="confirm">
>-            <input type="hidden" name="cancel_reserve" value="0" />
>-            <input type="submit" class="deny" value="Cancel" onclick="this.form.cancel_reserve.value = 1; this.form.submit();" />
> 
>             <input type="submit" class="approve" value="Confirm" />
> 
>+            <input type="hidden" name="cancel_reserve" value="0" />
>+            <input type="submit" class="deny" value="Cancel hold" onclick="this.form.cancel_reserve.value = 1; this.form.submit();" />
>+
>             <input type="hidden" name="print_slip" value="0" />
>             <input type="submit" value="Print and confirm" class="print" onclick="this.form.print_slip.value = 1; this.form.submit();" />
>             [% FOREACH inputloo IN inputloop %]
>-- 
>1.7.10.4

Actions: View | Diff | Splinter Review

Attachments on bug 15670: 47898 | 47935 | 47949