Attachment 47967 Details for Bug 14076 – Bug 14076: Do not use CGI->param in list context - opac-authorities-home.pl

[patch] Bug 14076: Do not use CGI->param in list context - opac-authorities-home.pl

Bug-14076-Do-not-use-CGI-param-in-list-context---o.patch (text/plain), 1.76 KB, created by Jonathan Druart on 2016-02-12 11:53:20 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2016-02-12 11:53:20 UTC

Size: 1.76 KB

patch

obsolete

>From 4264d1dfed429c55e82edc2add102726ceadb7a2 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Fri, 12 Feb 2016 11:49:28 +0000
>Subject: [PATCH] Bug 14076: Do not use CGI->param in list context -
> opac-authorities-home.pl
>
>See bug 15809 for more info on why we should not use CGI->param in list
>context.
>
>Note: I have not found any places where several values for the same
>params are passed to this script but, just in case, this patch won't
>change this ability.
>
>Test plan:
>Do an authority search at the OPAC
>Test with several values of the form.
>Confirm that the results are always the same before and after this
>patch.
>---
> opac/opac-authorities-home.pl | 11 ++++++-----
> 1 file changed, 6 insertions(+), 5 deletions(-)
>
>diff --git a/opac/opac-authorities-home.pl b/opac/opac-authorities-home.pl
>index 336a5fa..4447c82 100755
>--- a/opac/opac-authorities-home.pl
>+++ b/opac/opac-authorities-home.pl
>@@ -47,12 +47,13 @@ my $resultsperpage;
> my $authority_types = Koha::Authority::Types->search({}, { order_by => ['authtypetext']});
> 
> if ( $op eq "do_search" ) {
>-    my @marclist = ($query->param('marclist'));
>-    my @and_or = ($query->param('and_or'));
>-    my @excluding = ($query->param('excluding'),);
>-    my @operator = ($query->param('operator'));
>+    my @marclist = $query->multi_param('marclist');
>+    my @and_or = $query->multi_param('and_or');
>+    my @excluding = $query->multi_param('excluding');
>+    my @operator = $query->multi_param('operator');
>     my $orderby = $query->param('orderby');
>-    my @value = ($query->param('value') || "",);
>+    my @value = $query->multi_param('value');
>+    $value[0] ||= q||;
> 
>     $resultsperpage = $query->param('resultsperpage');
>     $resultsperpage = 20 if ( !defined $resultsperpage );
>-- 
>2.7.0

Actions: View | Diff | Splinter Review

Attachments on bug 14076: 39157 | 47967 | 48047 | 49584