Bugzilla – Attachment 47990 Details for
Bug 15777
Refactor loop in which Record::Processor does not initialize parameters
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 15777 - Fix base class to prove refactor and fix required
Bug-15777---Fix-base-class-to-prove-refactor-and-f.patch (text/plain), 1.12 KB, created by
Kyle M Hall (khall)
on 2016-02-12 15:11:36 UTC
(
hide
)
Description:
Bug 15777 - Fix base class to prove refactor and fix required
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2016-02-12 15:11:36 UTC
Size:
1.12 KB
patch
obsolete
>From 57faf6d2ace0c03957fdd52e57ddf78e82bcf154 Mon Sep 17 00:00:00 2001 >From: Mark Tompsett <mtompset@hotmail.com> >Date: Thu, 11 Feb 2016 23:23:27 -0500 >Subject: [PATCH] Bug 15777 - Fix base class to prove refactor and fix required >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >TEST PLAN >--------- >1) Apply the testing patch and this patch >2) prove -v t/RecordProcess.t > -- will complain about string use with "use strict". > This is because it is using the module name, instead > of the object instantiated with new(). >3) run koha qa test tools. > >Signed-off-by: Marc Véron <veron@veron.ch> > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > Koha/RecordProcessor/Base.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/Koha/RecordProcessor/Base.pm b/Koha/RecordProcessor/Base.pm >index dae41a0..84a28fa 100644 >--- a/Koha/RecordProcessor/Base.pm >+++ b/Koha/RecordProcessor/Base.pm >@@ -98,7 +98,7 @@ sub initialize { > my $self = shift; > my $params = shift; > >- #$self->params = $params; >+ $self->params($params); > > return $self; > } >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 15777
:
47941
|
47942
|
47943
|
47978
|
47979
|
47980
|
47988
| 47990 |
47991
|
48000