Bugzilla – Attachment 47991 Details for
Bug 15777
Refactor loop in which Record::Processor does not initialize parameters
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 15777 - Refactor and fix the RecordProcessor class
Bug-15777---Refactor-and-fix-the-RecordProcessor-c.patch (text/plain), 1.64 KB, created by
Kyle M Hall (khall)
on 2016-02-12 15:11:38 UTC
(
hide
)
Description:
Bug 15777 - Refactor and fix the RecordProcessor class
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2016-02-12 15:11:38 UTC
Size:
1.64 KB
patch
obsolete
>From 9c0c028eb5f524097937ac278e7016a6f8a76b89 Mon Sep 17 00:00:00 2001 >From: Mark Tompsett <mtompset@hotmail.com> >Date: Thu, 11 Feb 2016 23:30:36 -0500 >Subject: [PATCH] Bug 15777 - Refactor and fix the RecordProcessor class >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >TEST PLAN >--------- >1) Apply all three patches >2) prove -v t/RecordProcessor.t > -- all should be successful >3) run koha qa test tools > >Signed-off-by: Marc Véron <veron@veron.ch> > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > Koha/RecordProcessor.pm | 13 +++++++------ > 1 file changed, 7 insertions(+), 6 deletions(-) > >diff --git a/Koha/RecordProcessor.pm b/Koha/RecordProcessor.pm >index cbbd726..b9d2918 100644 >--- a/Koha/RecordProcessor.pm >+++ b/Koha/RecordProcessor.pm >@@ -103,13 +103,14 @@ sub new { > : $param->{filters}; > my @filters = ( ); > >- foreach my $filter (@{ $req_filters }) { >- next unless $filter; >- my $filter_module = $filter =~ m/:/ ? $filter : "Koha::Filter::${schema}::${filter}"; >+ foreach my $filter_name (@{ $req_filters }) { >+ next unless $filter_name; >+ # Fully qualify the module name. >+ my $filter_module = $filter_name =~ m/:/ ? $filter_name : "Koha::Filter::${schema}::${filter_name}"; > if (can_load( modules => { $filter_module => undef } )) { >- my $object = $filter_module->new(); >- $filter_module->initialize($param); >- push @filters, $object; >+ my $filter = $filter_module->new(); >+ $filter->initialize($param); >+ push @filters, $filter; > } > } > >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 15777
:
47941
|
47942
|
47943
|
47978
|
47979
|
47980
|
47988
|
47990
|
47991
|
48000