Bugzilla – Attachment 47992 Details for
Bug 15793
UX of circulation patron search with long lists of returned borrowers
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 15793 - UX of circulation patron search with long lists of returned borrowers
Bug-15793---UX-of-circulation-patron-search-with-l.patch (text/plain), 4.39 KB, created by
Owen Leonard
on 2016-02-12 15:16:29 UTC
(
hide
)
Description:
Bug 15793 - UX of circulation patron search with long lists of returned borrowers
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2016-02-12 15:16:29 UTC
Size:
4.39 KB
patch
obsolete
>From fc8b1745c363c510f53ce18347c9a72ca6665828 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Fri, 12 Feb 2016 10:11:29 -0500 >Subject: [PATCH] Bug 15793 - UX of circulation patron search with long lists > of returned borrowers >Content-Type: text/plain; charset="utf-8" > >Using form controls to select a patron from the list of patron search >results during checkout means that we have to have a submit button >somewhere on a potentially very long form. This patch proposes that we >use links to the patron records instead. > >This patch also makes a minor correction to the template to allow for >the correct layout grid to be used, and enables the display of full >library names in search results instead of branchcode. > >To test, apply the patch and search for a patron name from the >"Check out" form in the header. Clicking the name of any patron in the >search results should take you to the correct checkout page. >--- > .../prog/en/modules/circ/circulation.tt | 41 ++++------------------ > 1 file changed, 7 insertions(+), 34 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt >index 6fd722c..122c2a6 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt >@@ -103,21 +103,10 @@ $(document).ready(function() { > }); > > var table = $("#table_borrowers").dataTable($.extend(true, {}, dataTablesDefaults, { >- "aoColumnDefs": [ >- { "aTargets": [ 0 ], "bSortable": false, "bSearchable": false }, >- ], >- "aaSorting": [ 2, "asc" ], >+ "aaSorting": [ 1, "asc" ], > "sDom": "t", > "iDisplayLength": -1 > })); >- $(table).find('tbody tr').filter(':has(:radio:checked)').end().click(function(event) { >- $('#table_borrowers tbody tr').removeClass('selected'); >- $(this).addClass('selected'); >- if (event.target.type !== 'radio') { >- $(':radio', this).attr('checked', 'true') >- } >- }); >- > }); > > //]]> >@@ -135,7 +124,7 @@ $(document).ready(function() { > <strong>Checkouts</strong> > [% END %] > </div> >-[% IF ( $borrowers ) %] >+[% IF ( borrowers || message ) %] > <div id="doc" class="yui-t7"> > > <div id="bd"> >@@ -555,25 +544,13 @@ No patron matched <span class="ex">[% message %]</span> > [% END %] > > [% IF ( borrowers ) %] >-[% INCLUDE 'patron-toolbar.inc' %] >- >-<form method="post" action="/cgi-bin/koha/circ/circulation.pl" id="mainform" name="mainform" autocomplete="off"> >- <input type="hidden" name="restoreduedatespec" /> >-<fieldset id="circ_circulation_selectborrower" class="brief"> >- <legend>Patron selection</legend> >- >-[% IF (forceallow) %]<input type="hidden" name="forceallow" value="1">[% END %] >- <input type="hidden" name="branch" value="[% branch %]" /> >- <input type="hidden" name="printer" value="[% printer %]" /> >- <input type="hidden" name="duedatespec" value="[% duedatespec %]" /> >- <input type="hidden" name="stickyduedate" value="[% stickyduedate %]" /> >- >+ [% INCLUDE 'patron-toolbar.inc' %] >+ <h2>Patron selection</h2> > <table id="table_borrowers"> > <thead> > <tr> >- <th></th> > <th>Name</th> >- <th>Cardnumber</th> >+ <th>Card number</th> > <th>Category</th> > <th>Library</th> > <th>Address</th> >@@ -582,19 +559,15 @@ No patron matched <span class="ex">[% message %]</span> > <tbody> > [% FOREACH borrower IN borrowers %] > <tr> >- <td><input type="radio" name="borrowernumber" value="[% borrower.borrowernumber %]" /></td> >- <td>[% borrower.surname %], [% borrower.firstname %]</td> >+ <td><a href="/cgi-bin/koha/circ/circulation.pl?borrowernumber=[% borrower.borrowernumber %]">[% borrower.surname %], [% borrower.firstname %]</a></td> > <td>[% borrower.cardnumber %]</td> > <td>[% borrower.categorycode %]</td> >- <td>[% borrower.branchcode %]</td> >+ <td>[% Branches.GetName( borrower.branchcode ) %]</td> > <td>[% borrower.address %]</td> > </tr> > [% END %] > </tbody> > </table> >- <fieldset class="action"><input type="submit" value="Select" /></fieldset> >-</fieldset> >-</form> > [% ELSE %] > > <!-- BARCODE ENTRY --> >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 15793
:
47938
|
47940
|
47992
|
49457
|
49472
|
49520
|
49521
|
49611
|
49655
|
49656
|
49734