Attachment 48002 Details for Bug 15796 – Bug 15796: Remove C4::Koha::get_itemtypeinfos_of

[patch] Bug 15796: Remove C4::Koha::get_itemtypeinfos_of

Bug-15796-Remove-C4Kohagetitemtypeinfosof.patch (text/plain), 1.41 KB, created by Tomás Cohen Arazi (tcohen) on 2016-02-12 16:20:28 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2016-02-12 16:20:28 UTC

Size: 1.41 KB

patch

obsolete

>From 8c8adab7aad182b02372bde5d4bc59cdbd83931e Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Thu, 11 Feb 2016 13:50:42 +0000
>Subject: [PATCH] Bug 15796: Remove C4::Koha::get_itemtypeinfos_of
>
>This subroutine is no longer in use.
>
>Test plan:
>  git grep get_itemtypeinfos_of
>should not return any results.
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar>
>Trivial and needed removal.
>---
> C4/Koha.pm | 17 -----------------
> 1 file changed, 17 deletions(-)
>
>diff --git a/C4/Koha.pm b/C4/Koha.pm
>index 7171f16..353708b 100644
>--- a/C4/Koha.pm
>+++ b/C4/Koha.pm
>@@ -45,7 +45,6 @@ BEGIN {
> 		&GetItemTypes &getitemtypeinfo
>                 &GetItemTypesCategorized &GetItemTypesByCategory
> 		&GetSupportName &GetSupportList
>-		&get_itemtypeinfos_of
> 		&getframeworks &getframeworkinfo
>         &GetFrameworksLoop
> 		&getallthemes
>@@ -339,22 +338,6 @@ sub GetItemTypesByCategory {
>     return @$tmp;
> }
> 
>-sub get_itemtypeinfos_of {
>-    my @itemtypes = @_;
>-
>-    my $placeholders = join( ', ', map { '?' } @itemtypes );
>-    my $query = <<"END_SQL";
>-SELECT itemtype,
>-       description,
>-       imageurl,
>-       notforloan
>-  FROM itemtypes
>-  WHERE itemtype IN ( $placeholders )
>-END_SQL
>-
>-    return get_infos_of( $query, 'itemtype', undef, \@itemtypes );
>-}
>-
> =head2 getframework
> 
>   $frameworks = &getframework();
>-- 
>2.7.0

Actions: View | Diff | Splinter Review

Attachments on bug 15796: 47892 | 47959 | 48002