Bugzilla – Attachment 48004 Details for
Bug 15632
Move the messages related code to Koha::Patron::Messages
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 15632: Koha::Patron::Messages - Add new classes
Bug-15632-KohaPatronMessages---Add-new-classes.patch (text/plain), 6.09 KB, created by
Kyle M Hall (khall)
on 2016-02-12 18:54:28 UTC
(
hide
)
Description:
Bug 15632: Koha::Patron::Messages - Add new classes
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2016-02-12 18:54:28 UTC
Size:
6.09 KB
patch
obsolete
>From 8c8df852d11112e5e91ad31ab5862920790bc4dd Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Wed, 20 Jan 2016 17:31:50 +0000 >Subject: [PATCH] Bug 15632: Koha::Patron::Messages - Add new classes >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >The following 4 CRUD subroutines in C4::Members: >- AddMessage >- DeleteMessage >- GetMessagesCount >- GetMessages > >could be replaced with a new package based on Koha::Objets. >This patchset will add the 2 Koha::Patron::Message[s] classes, then use >it to replace the different calls to these subroutine. >It will slightly reduce the size of C4::Members > >Signed-off-by: Marc Véron <veron@veron.ch> > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > Koha/Patron/Message.pm | 44 ++++++++++++++++++++++++ > Koha/Patron/Messages.pm | 50 +++++++++++++++++++++++++++ > t/db_dependent/Koha/Patron/Messages.t | 63 +++++++++++++++++++++++++++++++++++ > 3 files changed, 157 insertions(+) > create mode 100644 Koha/Patron/Message.pm > create mode 100644 Koha/Patron/Messages.pm > create mode 100644 t/db_dependent/Koha/Patron/Messages.t > >diff --git a/Koha/Patron/Message.pm b/Koha/Patron/Message.pm >new file mode 100644 >index 0000000..dfe3d82 >--- /dev/null >+++ b/Koha/Patron/Message.pm >@@ -0,0 +1,44 @@ >+package Koha::Patron::Message; >+ >+# This file is part of Koha. >+# >+# Koha is free software; you can redistribute it and/or modify it under the >+# terms of the GNU General Public License as published by the Free Software >+# Foundation; either version 3 of the License, or (at your option) any later >+# version. >+# >+# Koha is distributed in the hope that it will be useful, but WITHOUT ANY >+# WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR >+# A PARTICULAR PURPOSE. See the GNU General Public License for more details. >+# >+# You should have received a copy of the GNU General Public License along >+# with Koha; if not, write to the Free Software Foundation, Inc., >+# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. >+ >+use Modern::Perl; >+ >+use Carp; >+ >+use Koha::Database; >+ >+use base qw(Koha::Object); >+ >+=head1 NAME >+ >+Koha::Patron::Message - Koha Message Object class >+ >+=head1 API >+ >+=head2 Class Methods >+ >+=cut >+ >+=head3 type >+ >+=cut >+ >+sub type { >+ return 'Message'; >+} >+ >+1; >diff --git a/Koha/Patron/Messages.pm b/Koha/Patron/Messages.pm >new file mode 100644 >index 0000000..4f2f9f4 >--- /dev/null >+++ b/Koha/Patron/Messages.pm >@@ -0,0 +1,50 @@ >+package Koha::Patron::Messages; >+ >+# This file is part of Koha. >+# >+# Koha is free software; you can redistribute it and/or modify it under the >+# terms of the GNU General Public License as published by the Free Software >+# Foundation; either version 3 of the License, or (at your option) any later >+# version. >+# >+# Koha is distributed in the hope that it will be useful, but WITHOUT ANY >+# WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR >+# A PARTICULAR PURPOSE. See the GNU General Public License for more details. >+# >+# You should have received a copy of the GNU General Public License along >+# with Koha; if not, write to the Free Software Foundation, Inc., >+# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. >+ >+use Modern::Perl; >+ >+use Carp; >+ >+use Koha::Database; >+ >+use Koha::Patron::Message; >+ >+use base qw(Koha::Objects); >+ >+=head1 NAME >+ >+Koha::Patron::Messages - Koha Message Object set class >+ >+=head1 API >+ >+=head2 Class Methods >+ >+=cut >+ >+=head3 type >+ >+=cut >+ >+sub type { >+ return 'Message'; >+} >+ >+sub object_class { >+ return 'Koha::Patron::Message'; >+} >+ >+1; >diff --git a/t/db_dependent/Koha/Patron/Messages.t b/t/db_dependent/Koha/Patron/Messages.t >new file mode 100644 >index 0000000..9cab130 >--- /dev/null >+++ b/t/db_dependent/Koha/Patron/Messages.t >@@ -0,0 +1,63 @@ >+#!/usr/bin/perl >+ >+# Copyright 2015 Koha Development team >+# >+# This file is part of Koha >+# >+# Koha is free software; you can redistribute it and/or modify it >+# under the terms of the GNU General Public License as published by >+# the Free Software Foundation; either version 3 of the License, or >+# (at your option) any later version. >+# >+# Koha is distributed in the hope that it will be useful, but >+# WITHOUT ANY WARRANTY; without even the implied warranty of >+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >+# GNU General Public License for more details. >+# >+# You should have received a copy of the GNU General Public License >+# along with Koha; if not, see <http://www.gnu.org/licenses>. >+ >+use Modern::Perl; >+ >+use Test::More tests => 4; >+ >+use Koha::Patron::Message; >+use Koha::Patron::Messages; >+use Koha::Database; >+ >+use t::lib::TestBuilder; >+ >+my $schema = Koha::Database->new->schema; >+$schema->storage->txn_begin; >+ >+my $builder = t::lib::TestBuilder->new; >+my $library = $builder->build( { source => 'Branch' } ); >+my $patron = $builder->build( { source => 'Borrower', values => { branchcode => $library->{branchcode} } } ); >+my $nb_of_messages = Koha::Patron::Messages->search->count; >+my $new_message_1 = Koha::Patron::Message->new( >+ { borrowernumber => $patron->{borrowernumber}, >+ branchcode => $library->{branchcode}, >+ message_type => 'L', >+ message => 'my message 1', >+ } >+)->store; >+my $new_message_2 = Koha::Patron::Message->new( >+ { borrowernumber => $patron->{borrowernumber}, >+ branchcode => $library->{branchcode}, >+ message_type => 'B', >+ message => 'my message 2', >+ } >+)->store; >+ >+like( $new_message_1->message_id, qr|^\d+$|, 'Adding a new message should have set the message_id'); >+is( Koha::Patron::Messages->search->count, $nb_of_messages + 2, 'The 2 messages should have been added' ); >+ >+my $retrieved_message_1 = Koha::Patron::Messages->find( $new_message_1->message_id ); >+is( $retrieved_message_1->message, $new_message_1->message, 'Find a message by id should return the correct message' ); >+ >+$retrieved_message_1->delete; >+is( Koha::Patron::Messages->search->count, $nb_of_messages + 1, 'Delete should have deleted the message' ); >+ >+$schema->storage->txn_rollback; >+ >+1; >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 15632
:
47091
|
47092
|
47093
|
47094
|
47095
|
47096
|
47097
|
47515
|
47516
|
47525
|
47571
|
47572
|
47573
|
47574
|
47575
|
47580
|
47581
|
47582
|
47583
|
47584
|
47585
|
47586
|
47587
|
48004
|
48009
|
48010
|
48011
|
48012
|
48013
|
48014
|
48015
|
48016
|
48017
|
48018
|
48020
|
48422
|
48423
|
48424
|
48425
|
48426
|
48427
|
48591
|
48592
|
48593