Attachment 4820 Details for Bug 5098 – proposed patch (passed QA)

[patch] proposed patch (passed QA)

0001-Bug-5098-Add-csv-headers-in-overdues.patch (text/plain), 1.27 KB, created by Paul Poulain on 2011-08-03 13:25:23 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Paul Poulain

Created: 2011-08-03 13:25:23 UTC

Size: 1.27 KB

patch

obsolete

>From 343af1a8db796c67844c6c7617cfb3cf9dcb1d85 Mon Sep 17 00:00:00 2001
>From: Julian Maurice <julian.maurice@biblibre.com>
>Date: Mon, 4 Apr 2011 16:52:03 +0200
>Subject: [PATCH] Bug 5098: Add csv headers in overdues
>
>Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
>Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
>---
> misc/cronjobs/overdue_notices.pl |    6 +++++-
> 1 files changed, 5 insertions(+), 1 deletions(-)
>
>diff --git a/misc/cronjobs/overdue_notices.pl b/misc/cronjobs/overdue_notices.pl
>index e605451..37774b5 100755
>--- a/misc/cronjobs/overdue_notices.pl
>+++ b/misc/cronjobs/overdue_notices.pl
>@@ -584,10 +584,14 @@ END_SQL
>                 local $, = "\f";    # pagebreak
>                 print @output_chunks;
>         }
>+        # Generate the content of the csv with headers
>+        my $content = join(";", qw(title name surname address1 address2 zipcode city email itemcount itemsinfo due_date issue_date)) . "\n";
>+        $content .= join( "\n", @output_chunks );
>+            
>         my $attachment = {
>             filename => defined $csvfilename ? 'attachment.csv' : 'attachment.txt',
>             type => 'text/plain',
>-            content => join( "\n", @output_chunks )
>+            content => $content, 
>         };
> 
>         my $letter = {
>-- 
>1.7.4.1
>

Actions: View | Diff | Splinter Review

Attachments on bug 5098: 3639 | 4087 | 4820