Bugzilla – Attachment 48315 Details for
Bug 15880
Serials new frequency link should be a toolbar button
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 15880 - Serials new frequency link should be a toolbar button
Bug-15880---Serials-new-frequency-link-should-be-a.patch (text/plain), 4.44 KB, created by
Marc Véron
on 2016-02-23 16:05:22 UTC
(
hide
)
Description:
Bug 15880 - Serials new frequency link should be a toolbar button
Filename:
MIME Type:
Creator:
Marc Véron
Created:
2016-02-23 16:05:22 UTC
Size:
4.44 KB
patch
obsolete
>From 0e1c5b47d20893d75f2096d9213961e9a68da718 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Mon, 22 Feb 2016 13:09:00 -0500 >Subject: [PATCH] Bug 15880 - Serials new frequency link should be a toolbar > button >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >This patch converts the "new frequency" link to a Bootstrap-style >toolbar button in order to maintain consistency. Also included in this >patch are some other minor markup corrections: > >- A colon and space after labels >- A 'Cancel' link instead of a button. >- "Required" classes for a required field. > >To test, apply the patch and go to Serials -> Manage frequencies. > >- Test the "New frequency" button >- Confirm that the changes to the entry form look correct. > >Followed test plan, displays as expected. >Signed-off-by: Marc Véron <veron@veron.ch> >--- > .../en/modules/serials/subscription-frequencies.tt | 20 ++++++++++++-------- > 1 file changed, 12 insertions(+), 8 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-frequencies.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-frequencies.tt >index 0986095..8442ed2 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-frequencies.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-frequencies.tt >@@ -106,11 +106,11 @@ $(document).ready(function() { > <fieldset class="rows"> > <ol> > <li> >- <label for="description">Description:</label> >- <input type="text" id="description" name="description" value="[% description %]" /> >+ <label class="required" for="description">Description: </label> >+ <input type="text" id="description" name="description" value="[% description %]" class="required" required="required" /> <span class="required">Required</span> > </li> > <li> >- <label for="unit">Unit</label> >+ <label for="unit">Unit: </label> > <select id="unit" name="unit"> > <option value="">None</option> > [% FOREACH unit IN units_loop %] >@@ -126,7 +126,7 @@ $(document).ready(function() { > </li> > <li><span class="hint">Note: one of the two following fields must be equal to 1</span></li> > <li> >- <label for="issuesperunit">Issues per unit</label> >+ <label for="issuesperunit">Issues per unit: </label> > [% IF (new) %] > <input type="text" id="issuesperunit" name="issuesperunit" value="1" size="3" /> > [% ELSE %] >@@ -134,7 +134,7 @@ $(document).ready(function() { > [% END %] > </li> > <li> >- <label for="unitsperissue">Units per issue</label> >+ <label for="unitsperissue">Units per issue: </label> > [% IF (new) %] > <input type="text" id="unitsperissue" name="unitsperissue" value="1" size="3" /> > [% ELSE %] >@@ -142,17 +142,22 @@ $(document).ready(function() { > [% END %] > </li> > <li> >- <label for="displayorder">Display order</label> >+ <label for="displayorder">Display order: </label> > <input type="text" id="displayorder" name="displayorder" value="[% displayorder %]" size="3" /> > </li> > </ol> > </fieldset> > <fieldset class="action"> > <input type="submit" value="Save" /> >- <input type="button" value="Cancel" onclick="window.location='/cgi-bin/koha/serials/subscription-frequencies.pl'" /> >+ <a href="/cgi-bin/koha/serials/subscription-frequencies.pl" class="cancel">Cancel</a> > </fieldset> > </form> > [% ELSE %] >+ >+ <div id="toolbar" class="btn-toolbar"> >+ <a class="btn btn-small" id="newfrequency" href="/cgi-bin/koha/serials/subscription-frequencies.pl?op=new"><i class="fa fa-plus"></i> New frequency</a> >+ </div> >+ > <h1>Frequencies</h1> > [% IF still_used %] > <div class="dialog"> >@@ -180,7 +185,6 @@ $(document).ready(function() { > </form> > </div> > [% END %] >- <a href="/cgi-bin/koha/serials/subscription-frequencies.pl?op=new">New frequency</a> > > [% IF (frequencies_loop.size) %] > <table id="frequenciest"> >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 15880
:
48304
|
48315
|
48463