Attachment 48341 Details for Bug 15697 – Bug 15697: Unnecessary comma between title and subtitle on opac-detail.pl

[patch] Bug 15697: Unnecessary comma between title and subtitle on opac-detail.pl

Bug-15697-Unnecessary-comma-between-title-and-subt.patch (text/plain), 2.69 KB, created by Nick Clemens (kidclamp) on 2016-02-24 15:39:47 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2016-02-24 15:39:47 UTC

Size: 2.69 KB

patch

obsolete

>From 28cc0bb48295d271fe5e10cc35cf28642fb6bf7a Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Thu, 28 Jan 2016 20:33:58 +0000
>Subject: [PATCH] Bug 15697: Unnecessary comma between title and subtitle on
> opac-detail.pl
>
>To test:
>1 - Go to Administration->Keyword to MARC mapping
>2 - Add a mapping (or ensure it exists)
>    Field name: subtitle
>    MARC field: 245
>    MARC subfield: b
>3 - View a record with a subtitle in the opac
>4 - Note in MARC 21 you have "Title of record:, subtitle of record"
>5 - Apply patch
>6 - View the record again and note the comma is no longer present.
>
>Note: this patch removes the comma only for MARC21 where subtitle is not
>repeatable. UNIMARC seems to be repeatable and does not include
>punctuation so I believe this may be needed there.
>
>Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
>Works as described. Comma removed from title of the window and breadcrumb
>section
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
>index 4b3db89..d358cec 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
>@@ -24,7 +24,7 @@
>     [% SET protocol = "http://" %]
> [% END %]
> [% INCLUDE 'doc-head-open.inc' %]
>-<title>[% IF ( LibraryNameTitle ) %][% LibraryNameTitle %][% ELSE %]Koha online[% END %] catalog &rsaquo; Details for: [% title |html %][% FOREACH subtitl IN subtitle %], [% subtitl.subfield |html %][% END %]</title>
>+<title>[% IF ( LibraryNameTitle ) %][% LibraryNameTitle %][% ELSE %]Koha online[% END %] catalog &rsaquo; Details for: [% title |html %][% FOREACH subtitl IN subtitle %][% UNLESS Koha.Preference('marcflavour')=='MARC21' %],[% END %] [% subtitl.subfield |html %][% END %]</title>
> [% INCLUDE 'doc-head-close.inc' %]
> [% IF ( bidi ) %]
>   [% BLOCK cssinclude %]<link rel="stylesheet" type="text/css" href="[% interface %]/[% theme %]/css/right-to-left.css" />[% END %]
>@@ -40,7 +40,7 @@
> <div class="main">
>     <ul class="breadcrumb">
>         <li><a href="/cgi-bin/koha/opac-main.pl">Home</a> <span class="divider">&rsaquo;</span></li>
>-        <li><a href="#">Details for: [% title |html %][% FOREACH subtitl IN subtitle %], [% subtitl.subfield |html %][% END %]</a></li>
>+        <li><a href="#">Details for: [% title %][% FOREACH subtitl IN subtitle %][% UNLESS Koha.Preference('marcflavour')=='MARC21' %],[% END %] [% subtitl.subfield |html %][% END %]</a></li>
>     </ul>
> 
>     <div class="container-fluid">
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 15697: 47410 | 47517 | 47524 | 47554 | 47577 | 47578 | 48341 | 48342