Bugzilla – Attachment 48393 Details for
Bug 13871
OverDrive message when user authentication fails
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 13871 [QA Followup] - Rename parameter to send_msg_on_invalid_credentials
Bug-13871-QA-Followup---Rename-parameter-to-sendms.patch (text/plain), 2.58 KB, created by
Marcel de Rooy
on 2016-02-26 09:49:32 UTC
(
hide
)
Description:
Bug 13871 [QA Followup] - Rename parameter to send_msg_on_invalid_credentials
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2016-02-26 09:49:32 UTC
Size:
2.58 KB
patch
obsolete
>From f0c413effd47ef37ba71d94ffe8f9de36b96ac63 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Thu, 23 Apr 2015 14:15:07 -0400 >Subject: [PATCH] Bug 13871 [QA Followup] - Rename parameter to > send_msg_on_invalid_credentials >Content-Type: text/plain; charset=utf-8 > >There are likely other services that would use this same feature. >Let's name it something a bit more general. > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > C4/SIP/Sip/MsgType.pm | 6 +++--- > etc/SIPconfig.xml | 3 ++- > 2 files changed, 5 insertions(+), 4 deletions(-) > >diff --git a/C4/SIP/Sip/MsgType.pm b/C4/SIP/Sip/MsgType.pm >index 451f228..51e45b8 100644 >--- a/C4/SIP/Sip/MsgType.pm >+++ b/C4/SIP/Sip/MsgType.pm >@@ -406,7 +406,7 @@ sub handle { > # > sub build_patron_status { > my ( $patron, $lang, $fields, $server ) = @_; >- my $overdrive_mode = $server->{account}->{'overdrive-mode'}; >+ my $send_msg_on_invalid_credentials = $server->{account}->{'send_msg_on_invalid_credentials'}; > my $patron_pwd = $fields->{ (FID_PATRON_PWD) }; > my $resp = (PATRON_STATUS_RESP); > my $password_ok = 1; >@@ -417,7 +417,7 @@ sub build_patron_status { > $password_rc = $patron->check_password($patron_pwd); > $password_ok = 0 unless $password_rc; > } >- elsif ( $overdrive_mode >+ elsif ( $send_msg_on_invalid_credentials > and not exists $fields->{'AL'} # not block_request > and not $patron_pwd ) # no password supplied > { >@@ -449,7 +449,7 @@ sub build_patron_status { > $resp .= maybe_add( FID_PRINT_LINE, $patron->print_line ); > } else { > >- # Invalid patron id (and/or passwd for overdrive_mode) >+ # Invalid patron id (and/or passwd for send_msg_on_invalid_credentials) > # Report that the user has no privs. > > # no personal name, and is invalid (if we're using 2.00) >diff --git a/etc/SIPconfig.xml b/etc/SIPconfig.xml >index 141bc4f..96da953 100644 >--- a/etc/SIPconfig.xml >+++ b/etc/SIPconfig.xml >@@ -42,7 +42,8 @@ > <login id="lpl-sc" password="1234" institution="LPL" /> > <login id="lpl-sc-beacock" password="xyzzy" > delimiter="|" error-detect="enabled" institution="LPL" >- send_patron_home_library_in_af="1" > >+ send_patron_home_library_in_af="1" >+ send_msg_on_invalid_credentials="1"> > <screen_msg_regex find="Greetings from Koha." replace="Welcome to your library!" /> > <screen_msg_regex find="Invalid patron barcode." replace="Barcode not found, are you sure this is your library card?" /> > </login> >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 13871
:
37539
|
37543
|
38451
|
38452
|
38453
|
38454
|
38455
|
45645
|
45646
|
45647
|
45648
|
45649
|
48386
|
48387
|
48388
|
48389
|
48390
|
48391
|
48392
|
48393
|
48667
|
48668
|
48669
|
48670
|
48671
|
48672
|
51421
|
51422