Bugzilla – Attachment 48432 Details for
Bug 15916
Regression: Many tables' sorting broken by JavaScript error
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 15916: Datatables - buttons area should be defined
Bug-15916-Datatables---buttons-area-should-be-defi.patch (text/plain), 1.57 KB, created by
Marcel de Rooy
on 2016-02-29 08:55:24 UTC
(
hide
)
Description:
Bug 15916: Datatables - buttons area should be defined
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2016-02-29 08:55:24 UTC
Size:
1.57 KB
patch
obsolete
>From 63ee1632b190ac9a23da6a63a5b7f318def8be17 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Mon, 29 Feb 2016 08:34:46 +0000 >Subject: [PATCH] Bug 15916: Datatables - buttons area should be defined >Content-Type: text/plain; charset=utf-8 > >Commit 243b797dd11bc0ac1f475195ab765ffbf2220f8b > Bug 15285: Update common files > >Set 'B' to the default dom of Datatable constructor. >This cannot work if there is no button defined. > >This patch defined an empty 'buttons' param for this constructor, DT >does not raised an error anymore when initialising. > >Test plan: >Confirm that the tables on the following tables are not broken: >- circ/waitingreserves.pl >- circ/reserveratios.pl >- patron_lists/lists.pl >- virtualshelves/shelves.pl >- acqui/invoices.pl >And with datatables: >- circ/circulation.pl >- admin/currency.pl > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > koha-tmpl/intranet-tmpl/prog/en/js/datatables.js | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/js/datatables.js b/koha-tmpl/intranet-tmpl/prog/en/js/datatables.js >index 71185c6..fd9dfd2 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/js/datatables.js >+++ b/koha-tmpl/intranet-tmpl/prog/en/js/datatables.js >@@ -24,6 +24,7 @@ var dataTablesDefaults = { > "sZeroRecords" : window.MSG_DT_ZERO_RECORDS || "No matching records found" > }, > "dom": '<"top pager"ilpfB>tr<"bottom pager"ip>', >+ "buttons": [], > "aLengthMenu": [[10, 20, 50, 100, -1], [10, 20, 50, 100, window.MSG_DT_ALL || "All"]], > "iDisplayLength": 20 > }; >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 15916
:
48431
|
48432
|
48479