Attachment 48441 Details for Bug 15111 – Bug 15111: Change X-Frame-Options with SAMEORIGIN

[patch] Bug 15111: Change X-Frame-Options with SAMEORIGIN

Bug-15111-Change-X-Frame-Options-with-SAMEORIGIN.patch (text/plain), 1.30 KB, created by Jonathan Druart on 2016-02-29 11:11:03 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2016-02-29 11:11:03 UTC

Size: 1.30 KB

patch

obsolete

>From 959a6316cd4fa87dcf821fa6238d5eaa0b50cfd3 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Fri, 13 Nov 2015 08:19:57 +0000
>Subject: [PATCH] Bug 15111: Change X-Frame-Options with SAMEORIGIN
>
>There are some places where frames are used, the greybox JS plugin for
>instance.
>
>We need either to allow them from Koha or replace this plugin.
>The easier for now is to switch the value from DENY with SAMEORIGIN.
>
>Test plan:
>- modify a record in a batch (tools/batch_record_modification.pl)
>- click on preview marc
>=> With only the previous patch you will get a blank page.
>=> With this patch apply, it will work as expected.
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> C4/Output.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/C4/Output.pm b/C4/Output.pm
>index 0527d654..0a0ae21 100644
>--- a/C4/Output.pm
>+++ b/C4/Output.pm
>@@ -269,7 +269,7 @@ sub output_with_http_headers {
>         charset           => 'UTF-8',
>         Pragma            => 'no-cache',
>         'Cache-Control'   => $cache_policy,
>-        'X-Frame-Options' => 'DENY',
>+        'X-Frame-Options' => 'SAMEORIGIN',
>     };
>     $options->{expires} = 'now' if $extra_options->{force_no_caching};
> 
>-- 
>2.7.0

Actions: View | Diff | Splinter Review

Attachments on bug 15111: 44289 | 44339 | 44622 | 44828 | 45444 | 48265 | 48440 | 48441 | 48442 | 48646 | 48647 | 48648