Bugzilla – Attachment 48476 Details for
Bug 15288
Error pages: Code duplication removal and better translatability
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 15288: (QA followup) Tests still point to old 500.tt file
Bug-15288-QA-followup-Tests-still-point-to-old-500.patch (text/plain), 1.51 KB, created by
Tomás Cohen Arazi (tcohen)
on 2016-02-29 17:32:07 UTC
(
hide
)
Description:
Bug 15288: (QA followup) Tests still point to old 500.tt file
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2016-02-29 17:32:07 UTC
Size:
1.51 KB
patch
obsolete
>From 63da10708d465b18756cbe11526c03fe686bee63 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@unc.edu.ar> >Date: Mon, 29 Feb 2016 14:27:59 -0300 >Subject: [PATCH] Bug 15288: (QA followup) Tests still point to old 500.tt file > >This patch fixes the t/db_dependent/Auth.t so they don't look for the removed >file and use the new one instead. > >To test: >- On master, run > $ prove t/db_dependent/Auth.t >=> FAIL: You get something similar to this: > >- Apply the patch >- Re-run the tests >=> SUCCESS: Tests now pass. > >Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar> >--- > t/db_dependent/Auth.t | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/t/db_dependent/Auth.t b/t/db_dependent/Auth.t >index 495467f..681476b 100644 >--- a/t/db_dependent/Auth.t >+++ b/t/db_dependent/Auth.t >@@ -130,7 +130,7 @@ $dbh->{RaiseError} = 1; > } > ( $template, $loggedinuser, $cookies ) = get_template_and_user( > { >- template_name => 'errors/500.tt', >+ template_name => 'errors/errorpage.tt', > query => $query, > type => "intranet", > authnotrequired => 1, >@@ -138,7 +138,7 @@ $dbh->{RaiseError} = 1; > } > ); > my $file_exists = ( -f $template->{filename} ) ? 1 : 0; >- is ( $file_exists, 1, 'The file errors/500.tt should be accessible (contains integers)' ); >+ is ( $file_exists, 1, 'The file errors/errorpage.tt should be accessible (contains integers)' ); > } > > # Check that there is always an OPACBaseURL set. >-- >2.7.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 15288
:
45354
|
45355
|
45356
|
45357
|
45396
|
45422
|
45424
|
45425
|
45426
|
46303
|
46316
|
46322
|
46323
|
46324
|
47464
| 48476