Attachment 48485 Details for Bug 14441 – Bug 14441 - TrackClicks cuts off/breaks URLs

[patch] Bug 14441 - TrackClicks cuts off/breaks URLs

Bug-14441---TrackClicks-cuts-offbreaks-URLs.patch (text/plain), 2.87 KB, created by Mason James on 2016-03-01 03:48:38 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Mason James

Created: 2016-03-01 03:48:38 UTC

Size: 2.87 KB

patch

obsolete

>From 01b877dadc8e27c54499d0462cc9b9e4292b3e42 Mon Sep 17 00:00:00 2001
>From: Mason James <mtj@kohaaloha.com>
>Date: Tue, 1 Mar 2016 16:26:06 +1300
>Subject: [PATCH] Bug 14441 - TrackClicks cuts off/breaks URLs
>Content-Type: text/plain; charset="utf-8"
>
>to test...
>
>1/ set TrackClicks syspref to 'track'
>
>2/ add a problematic multipart url to an item's 'url' field
>    example url: http://foo.corg?key1=val1&key2=val2
>
>3/ test url in opac-detail.pl - url is corrupt
>
>4/ apply patch - url is corrct
>---
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
>index 417d46a..193b40f 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
>@@ -351,7 +351,6 @@
>                                                 <a href="[% MARCurl.MARCURL %]" title="[% MARCurl.MARCURL %]">
>                                             [% END %]
>                                         [% END %]
>-
>                                         [% MARCurl.linktext %]</a>
>                                             [% IF ( MARCurl.notes ) %]
>                                                 <ul>
>@@ -1277,10 +1276,11 @@
>                             [% IF ITEM_RESULT.uri %]
>                                 [% IF trackclicks == 'track' || trackclicks == 'anonymous' %]
>                                     [% IF Koha.Preference("OPACURLOpenInNewWindow") %]
>-                                    <a target="_blank" href="/cgi-bin/koha/tracklinks.pl?uri=[% ITEM_RESULT.uri | url %]&amp;biblionumber=[% biblionumber |url %]&amp;itemnumber=[% ITEM_RESULT.itemnumber | url %]" property="url"> Link to resource </a>
>+                                    <a target="_blank" href="/cgi-bin/koha/tracklinks.pl?uri=[% ITEM_RESULT.uri | uri  %]&amp;biblionumber=[% biblionumber |url %]&amp;itemnumber=[% ITEM_RESULT.itemnumber | url %]" property="url"> Link to resource </a>
>                                     [% ELSE %]
>-                                    <a href="/cgi-bin/koha/tracklinks.pl?uri=[% ITEM_RESULT.uri | url %]&amp;biblionumber=[% biblionumber |url %]&amp;itemnumber=[% ITEM_RESULT.itemnumber | url %]" property="url"> Link to resource </a>
>+                                    <a href="/cgi-bin/koha/tracklinks.pl?uri=[% ITEM_RESULT.uri | uri %]&amp;biblionumber=[% biblionumber |url %]&amp;itemnumber=[% ITEM_RESULT.itemnumber | url %]" property="url"> Link to resource </a>
>                                     [% END %]
>+
>                                 [% ELSE %]
>                                     [% IF Koha.Preference("OPACURLOpenInNewWindow") %]
>                                     <a target="_blank" href="[% ITEM_RESULT.uri %]" property="url">[% ITEM_RESULT.uri %]</a>
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 14441: 48484 | 48485 | 48486 | 48501 | 48522 | 49556 | 49557