Bugzilla – Attachment 48486 Details for
Bug 14441
TrackClicks cuts off/breaks URLs
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED OFF] Bug 14441 - TrackClicks cuts off/breaks URLs
SIGNED-OFF-Bug-14441---TrackClicks-cuts-offbreaks-.patch (text/plain), 3.00 KB, created by
Katrin Fischer
on 2016-03-01 07:05:51 UTC
(
hide
)
Description:
[SIGNED OFF] Bug 14441 - TrackClicks cuts off/breaks URLs
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2016-03-01 07:05:51 UTC
Size:
3.00 KB
patch
obsolete
>From b3234ecf01cbdf4b8d2674a4593e4bff7cf55f3f Mon Sep 17 00:00:00 2001 >From: Mason James <mtj@kohaaloha.com> >Date: Tue, 1 Mar 2016 16:26:06 +1300 >Subject: [PATCH] [SIGNED OFF] Bug 14441 - TrackClicks cuts off/breaks URLs > >to test... > >1/ set TrackClicks syspref to 'track' > >2/ add a problematic multipart url to an item's 'url' field > example url: http://foo.corg?key1=val1&key2=val2 > >3/ test url in opac-detail.pl - url is corrupt > >4/ apply patch - url is corrct > >Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> >Only fixes the item URLs - a follow-up for the URLs >in the bibliographic record (856 for MARC21) is still >needed. >--- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >index 6c17888..0d28d32 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >@@ -348,7 +348,6 @@ > <a href="[% MARCurl.MARCURL %]" title="[% MARCurl.MARCURL %]"> > [% END %] > [% END %] >- > [% MARCurl.linktext %]</a> > [% IF ( MARCurl.notes ) %] > <ul> >@@ -1281,10 +1280,11 @@ > [% IF ITEM_RESULT.uri %] > [% IF trackclicks == 'track' || trackclicks == 'anonymous' %] > [% IF Koha.Preference("OPACURLOpenInNewWindow") %] >- <a target="_blank" href="/cgi-bin/koha/tracklinks.pl?uri=[% ITEM_RESULT.uri | url %]&biblionumber=[% biblionumber |url %]&itemnumber=[% ITEM_RESULT.itemnumber | url %]" property="url"> Link to resource </a> >+ <a target="_blank" href="/cgi-bin/koha/tracklinks.pl?uri=[% ITEM_RESULT.uri | uri %]&biblionumber=[% biblionumber |url %]&itemnumber=[% ITEM_RESULT.itemnumber | url %]" property="url"> Link to resource </a> > [% ELSE %] >- <a href="/cgi-bin/koha/tracklinks.pl?uri=[% ITEM_RESULT.uri | url %]&biblionumber=[% biblionumber |url %]&itemnumber=[% ITEM_RESULT.itemnumber | url %]" property="url"> Link to resource </a> >+ <a href="/cgi-bin/koha/tracklinks.pl?uri=[% ITEM_RESULT.uri | uri %]&biblionumber=[% biblionumber |url %]&itemnumber=[% ITEM_RESULT.itemnumber | url %]" property="url"> Link to resource </a> > [% END %] >+ > [% ELSE %] > [% IF Koha.Preference("OPACURLOpenInNewWindow") %] > <a target="_blank" href="[% ITEM_RESULT.uri %]" property="url">[% ITEM_RESULT.uri %]</a> >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14441
:
48484
|
48485
|
48486
|
48501
|
48522
|
49556
|
49557