Bugzilla – Attachment 48536 Details for
Bug 15927
Remove use of <tr class="highlight"> for alternating row colors.
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 15927 - Remove use of <tr class="highlight"> for alternating row colors
PASSED-QA-Bug-15927---Remove-use-of-tr-classhighli.patch (text/plain), 37.81 KB, created by
Katrin Fischer
on 2016-03-02 07:07:54 UTC
(
hide
)
Description:
[PASSED QA] Bug 15927 - Remove use of <tr class="highlight"> for alternating row colors
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2016-03-02 07:07:54 UTC
Size:
37.81 KB
patch
obsolete
>From cf62a8b0acda57d8d466d22b3fda5cf77ddc9c0a Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Fri, 26 Feb 2016 13:27:17 -0500 >Subject: [PATCH] [PASSED QA] Bug 15927 - Remove use of <tr class="highlight"> > for alternating row colors >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >The "highlight" class on table rows is unnecessary since we have a CSS >rule which defines colors for alternating row colors. This patch removes >use of the "highlight" class from templates and removes the definition >from staff-global.css > >To test, view the affected pages and confirm that the change has not >broken anything. > >Acquisitions -> Vendor -> View basket >Acquisitions -> Late orders >Acquisitions -> Ordered >Acquisitions -> Vendor -> Receive shipment >Acquisitions -> Spent >Acquisitions -> Vendor details -> Contracts table >Administration -> MARC frameworks (comment removed only) >Administration -> Class sources >Authorities -> Authority search results >Catalog -> Bibliographic detail page -> Items -> View item's checkout > history >Catalog -> subject.tt (is this template used?) >Cataloging -> Cataloging search results >Patrons -> Patron account >Reports -> Patrons who haven't checked out >Reports -> Statistics wizards -> Patrons >Reports -> Top lists -> Most-circulated items >Reports -> Inactive -> Items with no checkouts >Reports -> Reports dictionary >Reports -> Statistics wizards -> Circulation >Reports -> Statistics wizards -> Holds >Holds -> Place a hold -> Existing holds table >Serials -> New subscription -> Search for a vendor -> Search results >Serials -> Check expiration >Serials -> Subscription -> Serial collection >Serials -> Subscription -> Serial collection -> Edit serials >Suggestions >Tags -> View tags -> View titles with a tag >Tools -> Manage staged MARC records -> Batch (I think the affected >section of this template is obsolete) >Tools -> Log viewer -> Log result >Lists -> View lists (May be broken by Bug 15916) > >Note that if you search the templates for instances of a <tr> with a >"highlight" class you'll find two instances in slip templates which >refer to a class defined in printreceiptinvoice.css. > >Signed-off-by: Frédéric Demians <f.demians@tamil.fr> > Looks good. Haven't seen any regression. > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > koha-tmpl/intranet-tmpl/prog/en/css/addbiblio.css | 7 ++----- > koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css | 11 +---------- > koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt | 6 +++++- > .../intranet-tmpl/prog/en/modules/acqui/lateorders.tt | 3 +-- > koha-tmpl/intranet-tmpl/prog/en/modules/acqui/ordered.tt | 6 +----- > koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcels.tt | 4 ---- > koha-tmpl/intranet-tmpl/prog/en/modules/acqui/spent.tt | 5 ----- > .../intranet-tmpl/prog/en/modules/acqui/supplier.tt | 2 +- > .../prog/en/modules/admin/biblio_framework.tt | 2 +- > .../intranet-tmpl/prog/en/modules/admin/classsources.tt | 4 ---- > .../prog/en/modules/authorities/searchresultlist.tt | 4 ---- > .../intranet-tmpl/prog/en/modules/catalogue/results.tt | 4 ++-- > .../intranet-tmpl/prog/en/modules/catalogue/subject.tt | 2 +- > .../prog/en/modules/cataloguing/addbooks.tt | 10 +--------- > .../intranet-tmpl/prog/en/modules/cataloguing/additem.tt | 4 ++-- > .../intranet-tmpl/prog/en/modules/circ/bookcount.tt | 3 +-- > .../intranet-tmpl/prog/en/modules/members/boraccount.tt | 2 +- > .../prog/en/modules/reports/borrowers_out.tt | 6 +----- > .../prog/en/modules/reports/borrowers_stats.tt | 14 ++++++-------- > .../prog/en/modules/reports/cat_issues_top.tt | 2 +- > .../prog/en/modules/reports/catalogue_out.tt | 3 +-- > .../intranet-tmpl/prog/en/modules/reports/dictionary.tt | 6 +----- > .../prog/en/modules/reports/issues_stats.tt | 14 +++++--------- > .../prog/en/modules/reports/reserves_stats.tt | 16 ++++++---------- > .../intranet-tmpl/prog/en/modules/reserve/request.tt | 2 +- > .../prog/en/modules/serials/acqui-search-result.tt | 4 ---- > .../prog/en/modules/serials/checkexpiration.tt | 4 ---- > .../prog/en/modules/serials/serials-collection.tt | 4 ++-- > .../prog/en/modules/serials/serials-edit.tt | 4 ---- > .../prog/en/modules/suggestion/suggestion.tt | 2 +- > koha-tmpl/intranet-tmpl/prog/en/modules/tags/list.tt | 6 +----- > .../prog/en/modules/tools/manage-marc-import.tt | 8 ++++---- > koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt | 2 +- > .../prog/en/modules/virtualshelves/shelves.tt | 4 ---- > 34 files changed, 51 insertions(+), 129 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/css/addbiblio.css b/koha-tmpl/intranet-tmpl/prog/en/css/addbiblio.css >index dfd36f5..6098d4a 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/css/addbiblio.css >+++ b/koha-tmpl/intranet-tmpl/prog/en/css/addbiblio.css >@@ -140,14 +140,11 @@ a.tagnum { > width: 79.2%; > } > >-tr.active td { >+tbody tr.active:nth-child(2n+1) td, >+tbody tr.active td { > background-color: #FFFFCC; > } > >-tr.active.highlight td { >- background-color: #FEF4B4; >-} >- > #loading { > background-color: #FFF; > cursor: wait; >diff --git a/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css b/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css >index d5f9b30..ace744a 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css >+++ b/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css >@@ -264,21 +264,12 @@ table+table { > > .highlighted-row { background-color: orange !important } > >-tbody tr:nth-child(odd) td, >-tr.highlight td, >-tr.highlight th, >-tr.odd td, >-tr.odd.highlight td { >+tbody tr:nth-child(odd) td { > background-color : #F3F3F3; > border : 1px solid #BCBCBC; > border-right : 1px solid #BCBCBC; > } > >-tr.even td, tr.even.highlight td { >- background-color: #FFF; >- border-right : 1px solid #BCBCBC; >-} >- > .overdue td.od { > color : #cc0000; > font-weight : bold; >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt >index 3b3e1b1..67ee332 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt >@@ -446,7 +446,11 @@ > </tfoot> > <tbody> > [% FOREACH books_loo IN books_loop %] >- [% IF ( books_loo.order_received ) %]<tr class="disabled">[% ELSE %][% IF ( books_loo.toggle ) %]<tr class="highlight">[% ELSE %]<tr>[% END %][% END %] >+ [% IF ( books_loo.order_received ) %] >+ <tr class="disabled"> >+ [% ELSE %] >+ <tr> >+ [% END %] > <td> > [% books_loo.ordernumber %] > </td> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/lateorders.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/lateorders.tt >index f680401..5bebcb6 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/lateorders.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/lateorders.tt >@@ -131,8 +131,7 @@ $(document).ready(function() { > </thead> > <tbody> > [% FOREACH lateorder IN lateorders %] >- [% UNLESS ( loop.odd ) %]<tr class="highlight"> >- [% ELSE %]<tr>[% END %] >+ <tr> > <td> > <input type="checkbox" value="[% lateorder.ordernumber %]" data-booksellerid="[% lateorder.supplierid %]" name="ordernumber"> > </td> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/ordered.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/ordered.tt >index 486e632..bc9de26 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/ordered.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/ordered.tt >@@ -49,11 +49,7 @@ > </thead> > <tbody> > [% FOREACH order IN ordered %] >- [% IF loop.odd %] >- <tr class="highlight"> >- [% ELSE %] >- <tr> >- [% END %] >+ <tr> > <td class="cell"> > [% order.title %] > </td> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcels.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcels.tt >index 9013413..613098d 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcels.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcels.tt >@@ -98,11 +98,7 @@ > <tbody> > <!-- Actual Search Results --> > [% FOREACH searchresult IN searchresults %] >- [% UNLESS ( loop.odd ) %] >- <tr class="highlight"> >- [% ELSE %] > <tr> >- [% END %] > <td> > [% searchresult.number %] > </td> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/spent.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/spent.tt >index dbc69d6..754c200 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/spent.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/spent.tt >@@ -52,12 +52,7 @@ > </thead> > > [% FOREACH order IN spent %] >- [% IF loop.odd %] >- <tr class="highlight"> >- [% ELSE %] > <tr> >- [% END %] >- > <td class="cell"> > [% order.title %] > </td> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/supplier.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/supplier.tt >index 334d644..a1be60f 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/supplier.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/supplier.tt >@@ -369,7 +369,7 @@ function delete_contact(ev) { > </thead> > <tbody> > [% FOREACH contract IN contracts %] >- [% IF ( loop.even ) %]<tr class="highlight">[% ELSE %]<tr>[% END %] >+ <tr> > <td> > <a href="/cgi-bin/koha/admin/aqcontract.pl?op=add_form&contractnumber=[% contract.contractnumber %]&booksellerid=[% contract.booksellerid %]">[% contract.contractname %]</a> > </td> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/biblio_framework.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/biblio_framework.tt >index 5345022..f870026 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/biblio_framework.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/biblio_framework.tt >@@ -272,7 +272,7 @@ > > </td> > </tr> >- <!-- note highlight assignment appears backwards because we already have a normal row for Default --> >+ > [% FOREACH loo IN frameworks %] > <tr> > <td>[% loo.frameworkcode %]</td> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/classsources.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/classsources.tt >index 9c854eb..24f8bc4 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/classsources.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/classsources.tt >@@ -285,11 +285,7 @@ function CheckRuleForm(f) { > <th>Actions</th> > </tr> > [% FOREACH class_sort_rule IN class_sort_rules %] >- [% IF ( loop.odd ) %] > <tr> >- [% ELSE %] >- <tr class="highlight"> >- [% END %] > <td>[% class_sort_rule.rule %]</td> > <td>[% class_sort_rule.description %]</td> > <td>[% class_sort_rule.sort_routine %]</td> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/searchresultlist.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/searchresultlist.tt >index be2e156..e6bd923 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/searchresultlist.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/searchresultlist.tt >@@ -74,11 +74,7 @@ function searchauthority() { > [% END %] > </tr> > [% FOREACH resul IN result %] >- [% UNLESS ( loop.odd ) %] >- <tr data-authid="[% resul.authid %]" class="highlight"> >- [% ELSE %] > <tr data-authid="[% resul.authid %]"> >- [% END %] > <td>[% PROCESS authresult summary=resul.summary %]</td> > <td><a href="detail.pl?authid=[% resul.authid %]">Details</a></td> > [% UNLESS ( resul.isEDITORS ) %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt >index 65f35f1..68658fe 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt >@@ -440,7 +440,7 @@ var holdForPatron = function () { > <th>Count</th> > </tr> > [% FOREACH SEARCH_RESULT IN SEARCH_RESULTS %] >- [% IF ( loop.odd ) %]<tr>[% ELSE %]<tr class="highlight">[% END %] >+ <tr> > <td> > <a href="/cgi-bin/koha/catalogue/search.pl?idx=[% SEARCH_RESULT.scan_index_to_use %]&q=[% SEARCH_RESULT.scan_use |url %]"[% SEARCH_RESULT.title %]"">[% SEARCH_RESULT.title |html %]</a> > </td> >@@ -474,7 +474,7 @@ var holdForPatron = function () { > <!-- Actual Search Results --> > [% SET MaxSearchResultsItemsPerRecordStatusCheck = Koha.Preference('MaxSearchResultsItemsPerRecordStatusCheck') %] > [% FOREACH SEARCH_RESULT IN SEARCH_RESULTS %] >- [% IF ( loop.odd ) %]<tr>[% ELSE %]<tr class="highlight">[% END %] >+ <tr> > [% IF ( AmazonCoverImages || LocalCoverImages ) %] > <td> > [% IF ( LocalCoverImages) %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/subject.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/subject.tt >index a6b23ad..3bf55a9 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/subject.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/subject.tt >@@ -26,7 +26,7 @@ > <th>Subject headings</th> > </tr> > [% FOREACH SEARCH_RESULT IN SEARCH_RESULTS %] >- [% IF ( SEARCH_RESULT.even ) %]<tr class="highlight">[% ELSE %]<tr>[% END %] >+ <tr> > <td> > <a href="/cgi-bin/koha/search.pl?type=[% IF ( SEARCH_RESULT.opac ) %]opac[% ELSE %]intra[% END %]&subjectitems=[% SEARCH_RESULT.subject2 |html %]">[% SEARCH_RESULT.subject %]</a> > </td> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbooks.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbooks.tt >index 1a60e7e..7423430 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbooks.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbooks.tt >@@ -142,11 +142,7 @@ > [% IF ( CAN_user_editcatalogue_edit_items ) %]<th> </th>[% END %] > </tr> > [% FOREACH resultsloo IN resultsloop %] >- [% IF ( loop.even ) %] >- <tr class="highlight"> >- [% ELSE %] >- <tr> >- [% END %] >+ <tr> > <td><input type="checkbox" class="selection" id="bib[% resultsloo.biblionumber %]" name="biblionumber" value="[% resultsloo.biblionumber %]" /></td> > <td> > <p> >@@ -231,11 +227,7 @@ > [% IF ( CAN_user_editcatalogue_edit_catalogue ) %]<th> </th>[% END %] > </tr> > [% FOREACH breeding_loo IN breeding_loop %] >- [% IF ( loop.odd ) %] > <tr> >- [% ELSE %] >- <tr class="highlight"> >- [% END %] > <td>[% breeding_loo.title |html %] > [% breeding_loo.author %]</td> > <td>[% breeding_loo.isbn %]</td> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt >index fd0054b..1de8960 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt >@@ -157,9 +157,9 @@ function confirm_deletion() { > [% FOREACH item_loo IN item_loop %] > [% IF ( item_loo.itemnumber == itemnumber) %] > [% IF item_loo.nomod %] >- <tr id="row[% item_loo.itemnumber %]" class="active highlight"> >+ <tr id="row[% item_loo.itemnumber %]" class="active"> > [% ELSE %] >- <tr id="row[% item_loo.itemnumber %]" class="active editable highlight"> >+ <tr id="row[% item_loo.itemnumber %]" class="active editable"> > [% END %] > [% ELSE %] > [% IF item_loo.nomod %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/bookcount.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/bookcount.tt >index f7b4765..be52899 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/bookcount.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/bookcount.tt >@@ -4,7 +4,6 @@ > [% INCLUDE 'doc-head-close.inc' %] > <script type="text/javascript"> > $(document).ready(function(){ >- $(".striped tr:even").addClass("highlight"); > $("tr.mybranch td").css("background-color", "#CFE7FF"); > }); > </script> >@@ -33,7 +32,7 @@ $(document).ready(function(){ > <td>[% count %]</td> > </tr> > </table> >-<table class="striped"> >+<table> > <tr> > <th>Library</th> > <th>No. of times checked out</th> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt >index 824c41c..09b5c67 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt >@@ -75,7 +75,7 @@ $(document).ready(function() { > <!-- FIXME: Shouldn't hardcode dollar signs, since Euro or Pound might be needed --> > [% FOREACH account IN accounts %] > >- [% IF ( loop.odd ) %]<tr>[% ELSE %]<tr class="highlight">[% END %] >+ <tr> > <td><span title="[% account.date %]">[% account.date |$KohaDates %]</span></td> > <td> > [% SWITCH account.accounttype %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/borrowers_out.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/borrowers_out.tt >index bc6e6b2..5f7f701 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/borrowers_out.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/borrowers_out.tt >@@ -40,11 +40,7 @@ $(document).ready(function(){ > [% END %] > </tr> > [% FOREACH loopro IN mainloo.looprow %] >- [% UNLESS ( loop.odd ) %] >- <tr class="highlight"> >- [% ELSE %] >- <tr> >- [% END %] >+ <tr> > <td>[% loopro.rowtitle %]</td> > [% FOREACH loopcel IN loopro.loopcell %] > <td>[% IF ( loopcel.value ) %][% loopcel.value %][% END %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/borrowers_stats.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/borrowers_stats.tt >index 3c5397c..4c659d4 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/borrowers_stats.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/borrowers_stats.tt >@@ -40,8 +40,7 @@ > <th>TOTAL</th> > </tr> > [% FOREACH loopro IN mainloo.looprow %] >- [% UNLESS ( loop.odd ) %]<tr class="highlight"> >- [% ELSE %]<tr>[% END %] >+ <tr> > <td>[% IF ( loopro.rowtitle_display ) %][% loopro.rowtitle_display %][% ELSE %][% loopro.rowtitle %][% END %] > </td> > [% FOREACH loopcel IN loopro.loopcell %] >@@ -74,7 +73,7 @@ > </tr> > </thead> > <tbody> >- <tr class="highlight"> >+ <tr> > <td>Patron category</td> > <td><input type="radio" name="Line" value="categorycode" /></td> > <td><input type="radio" name="Column" value="categorycode" /></td> >@@ -91,7 +90,7 @@ > <td colspan="2"></td> > <td ><select name="status"><option value=""> </option><option value="debarred">restricted</option><option value="gonenoadress">gone no address</option><option value="lost">lost</option></select></td> > </tr> >- <tr class="highlight"> >+ <tr> > <td>Patron activity</td> > <td colspan="2"><select name="period" id="period"> > <option value="1">1</option> >@@ -134,7 +133,7 @@ > <td> </td> > </tr> > >- <tr class="highlight"> >+ <tr> > <td>Library</td> > <td><input type="radio" name="Line" value="branchcode" /></td> > <td><input type="radio" name="Column" value="branchcode" /></td> >@@ -168,7 +167,7 @@ > </td> > </tr> > [% IF ( SORT1_LOOP ) %] >- <tr class="highlight"> >+ <tr> > <td>Sort1</td> > <td><input type="radio" name="Line" value="sort1" /></td> > <td><input type="radio" name="Column" value="sort1" /></td> >@@ -185,8 +184,7 @@ > <input type="hidden" name="Filter" /> > [% END %] > [% IF ( SORT2_LOOP ) %] >- [% UNLESS ( SORT1_LOOP ) %]<tr class="highlight"> >- [% ELSE %]<tr>[% END %] >+ <tr> > <td>Sort2</td> > <td><input type="radio" name="Line" value="sort2" /></td> > <td><input type="radio" name="Column" value="sort2" /></td> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/cat_issues_top.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/cat_issues_top.tt >index 8df052b..2c64f59 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/cat_issues_top.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/cat_issues_top.tt >@@ -75,7 +75,7 @@ > [% END %] > </tr> > [% FOREACH loopro IN mainloo.looprow %] >-[% IF ( loopro.hilighted ) %]<tr class="highlighted">[% ELSE %]<tr>[% END %] >+ <tr> > <td>[% loopro.rowtitle %]</td> > [% FOREACH loopcel IN loopro.loopcell %] > <td> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/catalogue_out.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/catalogue_out.tt >index 01af898..76517f3 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/catalogue_out.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/catalogue_out.tt >@@ -66,8 +66,7 @@ > </tr> > [% IF ( looptable.looprow ) %] > [% FOREACH loopro IN looptable.looprow %] >- [% UNLESS ( loop.odd ) %]<tr class="highlight"> >- [% ELSE %]<tr>[% END %] >+ <tr> > > <td>[% loop.count %]</td> > <td>[% IF ( loopro.itemcallnumber ) %][% loopro.itemcallnumber %][% ELSE %]No call number[% END %]</td> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/dictionary.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/dictionary.tt >index c21af0d..63aa5d7 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/dictionary.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/dictionary.tt >@@ -71,11 +71,7 @@ > <th> </th> > </tr> > [% FOREACH definition IN definitions %] >- [% UNLESS ( loop.odd ) %] >- <tr class="highlight" valign="top"> >- [% ELSE %] >- <tr valign="top"> >- [% END %] >+ <tr> > <td>[% definition.name %]</td> > <td>[% definition.description %]</td> > <td>[% definition.areaname %]</td> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/issues_stats.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/issues_stats.tt >index 52f1cfa..789ae51 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/issues_stats.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/issues_stats.tt >@@ -44,11 +44,7 @@ > <th>TOTAL</th> > </tr> > [% FOREACH loopro IN mainloo.looprow %] >- [% IF ( loop.odd ) %] > <tr> >- [% ELSE %] >- <tr class="highlight"> >- [% END %] > <td>[% loopro.rowtitle_display or "UNKNOWN VALUE" |html %]</td> > [% FOREACH loopcel IN loopro.loopcell %] > <td>[% loopcel.value %]</td> >@@ -88,7 +84,7 @@ > <span class="hint">[% INCLUDE 'date-format.inc' %]</span> > </td> > </tr> >- <tr class="highlight"> >+ <tr> > <td><label for="PeriodTypeSel">Type:</label><select name="PeriodTypeSel" id="PeriodTypeSel"> > <option value ="issue">Checkout</option> > <option value ="renew">Renewal</option> >@@ -142,7 +138,7 @@ > </select> > </td> > </tr> >- <tr class="highlight"> >+ <tr> > <td>Item type</td> > <td><input type="radio" name="Line" value="itemtype" /></td> > <td><input type="radio" name="Column" value="itemtype" /></td> >@@ -166,7 +162,7 @@ > </select> > </td> > </tr> >- <tr class="highlight"> >+ <tr> > <td>Collection</td> > <td><input type="radio" name="Line" value="items.ccode" /></td> > <td><input type="radio" name="Column" value="items.ccode" /></td> >@@ -190,7 +186,7 @@ > </select> > </td> > </tr> >- <tr class="highlight"> >+ <tr> > <td>Item call number</td> > <td></td> > <td></td> >@@ -210,7 +206,7 @@ > </tr> > [% END %] > [% IF ( hassort2 ) %] >- <tr class="highlight"><td>Patron sort 2</td> >+ <tr><td>Patron sort 2</td> > <td><input type="radio" name="Line" value="borrowers.sort2" /></td> > <td><input type="radio" name="Column" value="borrowers.sort2" /></td> > <td><select name="Filter" id="sort2"> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/reserves_stats.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/reserves_stats.tt >index 641cbc6..ac19ed7 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/reserves_stats.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/reserves_stats.tt >@@ -118,11 +118,7 @@ > <th>TOTAL</th> > </tr> > [% FOREACH loopro IN mainloo.looprow %] >- [% IF ( loop.odd ) %] > <tr> >- [% ELSE %] >- <tr class="highlight"> >- [% END %] > <td>[% loopro.rowtitle_display or "UNKNOWN VALUE" |html %]</td> > [% FOREACH loopcel IN loopro.loopcell %] > <td align="center"> >@@ -168,7 +164,7 @@ > <input type="checkbox" name="filter_reservestatus_or_5" value="5" /> Cancelled > </td> > </tr> >- <tr class="highlight"> >+ <tr> > <td>Hold Date</td> > <td><input type="radio" name="Line" value="reservedate" /></td> > <td><input type="radio" name="Column" value="reservedate" /></td> >@@ -220,7 +216,7 @@ > </select> > </td> > </tr> >- <tr class="highlight"> >+ <tr> > <td>Item type</td> > <td><input type="radio" name="Line" value="items.itype" /></td> > <td><input type="radio" name="Column" value="items.itype" /></td> >@@ -244,7 +240,7 @@ > </select> > </td> > </tr> >- <tr class="highlight"> >+ <tr> > <td>Holding library</td> > <td><input type="radio" name="Line" value="items.holdingbranch" /></td> > <td><input type="radio" name="Column" value="items.holdingbranch" /></td> >@@ -268,7 +264,7 @@ > </select> > </td> > </tr> >- <tr class="highlight"> >+ <tr> > <td>Collection</td> > <td><input type="radio" name="Line" value="items.ccode" /></td> > <td><input type="radio" name="Column" value="items.ccode" /></td> >@@ -292,7 +288,7 @@ > </select> > </td> > </tr> >- <tr class="highlight"> >+ <tr> > <td>Item call number</td> > <td></td> > <td></td> >@@ -312,7 +308,7 @@ > </tr> > [% END %] > [% IF ( hassort2 ) %] >- <tr class="highlight"><td>Patron sort 2</td> >+ <tr><td>Patron sort 2</td> > <td><input type="radio" name="Line" value="borrowers.sort2" /></td> > <td><input type="radio" name="Column" value="borrowers.sort2" /></td> > <td><select name="filter_borrowers.sort2" id="sort2"> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >index b9c4fb9..473cfb4 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >@@ -683,7 +683,7 @@ function checkMultiHold() { > [% IF SuspendHoldsIntranet %]<th> </th><!-- Suspend Holds Column Header -->[% END %] > </tr> > [% FOREACH reserveloo IN biblioloo.reserveloop %] >- [% UNLESS ( loop.odd ) %]<tr class="highlight">[% ELSE %]<tr>[% END %] >+ <tr> > <td> > <input type="hidden" name="reserve_id" value="[% reserveloo.reserve_id %]" /> > <input type="hidden" name="borrowernumber" value="[% reserveloo.borrowernumber %]" /> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/acqui-search-result.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/acqui-search-result.tt >index 3c84b50..94efaf7 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/acqui-search-result.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/acqui-search-result.tt >@@ -27,11 +27,7 @@ function GetIt(aqbooksellerid,name) > <th>Select</th> > </tr> > [% FOREACH loop_supplier IN loop_suppliers %] >- [% UNLESS ( loop.odd ) %] >- <tr class="highlight"> >- [% ELSE %] > <tr> >- [% END %] > <td>[% loop_supplier.name %]</td> > <td><a href="#" onclick="GetIt([% loop_supplier.aqbooksellerid %],$(this).parent().prev().text())">Choose</a></td> > </tr> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/checkexpiration.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/checkexpiration.tt >index 657f91d..7fb484b 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/checkexpiration.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/checkexpiration.tt >@@ -103,11 +103,7 @@ > <th colspan="2"> </th> > </tr> > [% FOREACH subscriptions_loo IN subscriptions_loop %] >- [% IF ( subscriptions_loo.toogle ) %] >- <tr class="highlight"> >- [% ELSE %] > <tr> >- [% END %] > <td> > [% subscriptions_loo.issn %] > </td> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt >index bf1dc7a..f4b6785 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt >@@ -116,7 +116,7 @@ $(document).ready(function() { > <th>Renew</th> > </tr> > [% FOREACH subscription IN subscriptions %] >- [% UNLESS ( loop.odd ) %]<tr class="highlight">[% ELSE %]<tr>[% END %] >+ <tr> > <td><a href="subscription-detail.pl?subscriptionid=[% subscription.subscriptionid %]"># [% subscription.subscriptionid %]</a> </td> > <td>[% subscription.frequency.description %]</td> > <td>[% subscription.numberpattern.label %]</td> >@@ -222,7 +222,7 @@ $(document).ready(function() { > </thead> > <tbody> > [% FOREACH serial IN year.serials %] >- [% UNLESS ( loop.odd ) %]<tr class="highlight">[% ELSE %]<tr>[% END %] >+ <tr> > [% IF ( CAN_user_serials_receive_serials ) %] > <td> > [% UNLESS CAN_user_serials_receive_serials %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt >index 23f0bdc..2121547 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt >@@ -116,11 +116,7 @@ $(document).ready(function() { > <th>Notes</th> > </tr> > [% FOREACH serialslis IN serialslist %] >- [% UNLESS ( loop.odd ) %] >- <tr class="highlight"> >- [% ELSE %] > <tr> >- [% END %] > <td> > <input type="hidden" name="serialid" value="[% serialslis.serialid %]" /> > <input type="hidden" name="biblionumber" value="[% serialslis.biblionumber %]" /> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt >index 547265d..e518afa 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt >@@ -505,7 +505,7 @@ h4.local_collapse a { font-size : 80%; text-decoration: none; } fieldset.brief o > </thead> > <tbody> > [% FOREACH suggestions_loo IN suggestion.suggestions_loop %] >- [% IF ( suggestions_loo.even ) %]<tr class="highlight">[% ELSE %]<tr>[% END %] >+ <tr> > <td> > <input type="checkbox" name="edit_field" value="[% suggestions_loo.suggestionid %]" /> > </td> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tags/list.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tags/list.tt >index f6ce767..01e9233 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tags/list.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tags/list.tt >@@ -47,11 +47,7 @@ tr.selected { background-color : #FFFFCC; } tr.selected td { background-color : > </tr></thead> > > [% FOREACH title IN titles %] >- [% IF ( title.even ) %] >- <tr class="highlight"> >- [% ELSE %] >- <tr> >- [% END %] >+ <tr> > <td>[% INCLUDE 'biblio-default-view.inc' biblionumber = title.biblionumber %][% title.title |html %][% FOREACH subtitl IN title.subtitle %] [% subtitl.subfield %][% END %]</a> > [% title.author %] > <p>[% IF ( title.publishercode ) %]- [% title.publishercode|html %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/manage-marc-import.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/manage-marc-import.tt >index 84dd2db..f8cbdd0 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/manage-marc-import.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/manage-marc-import.tt >@@ -10,9 +10,9 @@ > <tr> > <td /> > [% IF ( record.record_type == 'biblio' ) %] >- <td class="highlight" colspan="5">Matches biblio [% record_lis.match_id %] (score = [% record_lis.match_score %]): <a href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% record_lis.match_id %]">[% record_lis.match_citation %]</a></td> >+ <td colspan="5">Matches biblio [% record_lis.match_id %] (score = [% record_lis.match_score %]): <a href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% record_lis.match_id %]">[% record_lis.match_citation %]</a></td> > [% ELSIF ( record.record_type == 'auth' ) %] >- <td class="highlight" colspan="5">Matches authority [% record_lis.match_id %] (score = [% record_lis.match_score %]): <a href="/cgi-bin/koha/authorities/detail.pl?authid=[% record_lis.match_id %]">[% record_lis.match_citation %]</a> | >+ <td colspan="5">Matches authority [% record_lis.match_id %] (score = [% record_lis.match_score %]): <a href="/cgi-bin/koha/authorities/detail.pl?authid=[% record_lis.match_id %]">[% record_lis.match_citation %]</a> | > <a href="/cgi-bin/koha/authorities/merge.pl?mergereference=breeding&authid=[% record_lis.match_id %]&authid=[% record_lis.import_record_id %]">Merge</a> > </td> > [% END %] >@@ -20,7 +20,7 @@ > [% ELSIF ( record.record_type == 'auth') %] > <tr data-authid="[% record_lis.import_record_id %]"> > <td /> >- <td class="highlight" colspan="4"><a href="#" class="merge_auth">Search for a record to merge in a new window</a></td> >+ <td colspan="4"><a href="#" class="merge_auth">Search for a record to merge in a new window</a></td> > </tr> > [% END %] > [% END %] >@@ -423,7 +423,7 @@ Page > <th>Action</th> > </tr> > [% FOREACH batch_lis IN batch_list %] >- [% UNLESS ( loop.odd ) %]<tr class="highlight">[% ELSE %]<tr>[% END %] >+ <tr> > <td>[% batch_lis.import_batch_id %]</td> > <td><a href="[% batch_lis.script_name %]?import_batch_id=[% batch_lis.import_batch_id %]">[% batch_lis.file_name %]</a></td> > <td>[% batch_lis.comments %]</td> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt >index 744dee7..d5f616b 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt >@@ -171,7 +171,7 @@ > </thead> > <tbody> > [% FOREACH loopro IN looprow %] >- [% UNLESS ( loop.odd ) %]<tr class="highlight">[% ELSE %]<tr>[% END %] >+ <tr> > <td>[% loopro.timestamp %]</td> > <td> > <a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% loopro.user %]" title="display detail for this librarian."> [% IF ( loopro.userfirstname ) || ( loopro.usersurname ) %][% loopro.userfirstname %] [% loopro.usersurname %] ([% loopro.user %]) [% ELSE %][% loopro.user %][% END %]</a> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt >index 8f91e29..ea66256 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt >@@ -435,11 +435,7 @@ function placeHold () { > </th> > </tr> > [% FOREACH itemsloo IN itemsloop %] >- [% UNLESS ( loop.odd ) %] >- <tr class="highlight"> >- [% ELSE %] > <tr> >- [% END %] > [% IF itemsloop %] > <td> > <input type="checkbox" class="selection" value="[% itemsloo.biblionumber %]" name="biblionumber" /> >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 15927
:
48456
|
48535
| 48536