Attachment 48541 Details for Bug 15755 – Bug 15755: Display default item type as "All" in circ rules

[patch] Bug 15755: Display default item type as "All" in circ rules

Bug-15755-Display-default-item-type-as-All-in-circ.patch (text/plain), 1.41 KB, created by Chris Cormack on 2016-03-02 08:38:25 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Cormack

Created: 2016-03-02 08:38:25 UTC

Size: 1.41 KB

patch

obsolete

>From 48a7d0e62111ba9f5a07d8f48637e385466081a7 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Mon, 8 Feb 2016 13:00:37 +0000
>Subject: [PATCH] Bug 15755: Display default item type as "All" in circ rules
>
>Bug 15354 did not fix correctly the issue with the item type display.
>The default item type '*' should be "All", at the moment nothing is
>displayed in the column.
>
>Test plan:
>1/ Define a rule for default item types (All/*) and for specific item
>types.
>2/ Translate some item type descriptions used in previous step
>3/ Default item type should be "All" and correct translations should be
>displayed.
>
>Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
>---
> admin/smart-rules.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/admin/smart-rules.pl b/admin/smart-rules.pl
>index 5be4c0a..da4e577 100755
>--- a/admin/smart-rules.pl
>+++ b/admin/smart-rules.pl
>@@ -461,7 +461,7 @@ $sth2->execute($language, $branch);
> 
> while (my $row = $sth2->fetchrow_hashref) {
>     $row->{'current_branch'} ||= $row->{'branchcode'};
>-    $row->{translated_description} ||= $row->{translated_description};
>+    $row->{humanitemtype} ||= $row->{itemtype};
>     $row->{default_translated_description} = 1 if $row->{humanitemtype} eq '*';
>     $row->{'humancategorycode'} ||= $row->{'categorycode'};
>     $row->{'default_humancategorycode'} = 1 if $row->{'humancategorycode'} eq '*';
>-- 
>2.7.0

Actions: View | Diff | Splinter Review

Attachments on bug 15755: 47738 | 48541 | 48581