Bugzilla – Attachment 48684 Details for
Bug 14306
Show URL from MARC21 field 555$u in basket and detail
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 14306: Remove call to GetMarcNotes from sendshelf
PASSED-QA-Bug-14306-Remove-call-to-GetMarcNotes-fr.patch (text/plain), 2.89 KB, created by
Katrin Fischer
on 2016-03-04 13:23:06 UTC
(
hide
)
Description:
[PASSED QA] Bug 14306: Remove call to GetMarcNotes from sendshelf
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2016-03-04 13:23:06 UTC
Size:
2.89 KB
patch
obsolete
>From 39ae7264ad55c81c6101a280a6df0d7a38507c2c Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Thu, 27 Aug 2015 10:01:53 +0200 >Subject: [PATCH] [PASSED QA] Bug 14306: Remove call to GetMarcNotes from > sendshelf >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >Just as mentioned in the first patch for sendbasket, I discovered that >the call of GetMarcNotes is not really used in sendshelf. The array is >passed to the template, but the template does not use it. (It uses the >information from GetBiblioData.) > >Test plan: >[1] Send a list that includes a record with some notes (opac and staff). > >Signed-off-by: Marc Véron <veron@veron.ch> > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > opac/opac-sendshelf.pl | 2 -- > virtualshelves/sendshelf.pl | 2 -- > 2 files changed, 4 deletions(-) > >diff --git a/opac/opac-sendshelf.pl b/opac/opac-sendshelf.pl >index d4d31d8..a0682bc 100755 >--- a/opac/opac-sendshelf.pl >+++ b/opac/opac-sendshelf.pl >@@ -90,7 +90,6 @@ if ( $email ) { > my $fw = GetFrameworkCode($biblionumber); > my $dat = GetBiblioData($biblionumber); > my $record = GetMarcBiblio($biblionumber, 1); >- my $marcnotesarray = GetMarcNotes( $record, $marcflavour ); > my $marcauthorsarray = GetMarcAuthors( $record, $marcflavour ); > my $marcsubjctsarray = GetMarcSubjects( $record, $marcflavour ); > my $subtitle = GetRecordValue('subtitle', $record, $fw); >@@ -98,7 +97,6 @@ if ( $email ) { > my @items = GetItemsInfo( $biblionumber ); > > $dat->{ISBN} = GetMarcISBN($record, $marcflavour); >- $dat->{MARCNOTES} = $marcnotesarray; > $dat->{MARCSUBJCTS} = $marcsubjctsarray; > $dat->{MARCAUTHORS} = $marcauthorsarray; > $dat->{'biblionumber'} = $biblionumber; >diff --git a/virtualshelves/sendshelf.pl b/virtualshelves/sendshelf.pl >index cb46ce2..02999ea 100755 >--- a/virtualshelves/sendshelf.pl >+++ b/virtualshelves/sendshelf.pl >@@ -81,7 +81,6 @@ if ($email) { > my $fw = GetFrameworkCode($biblionumber); > my $dat = GetBiblioData($biblionumber); > my $record = GetMarcBiblio($biblionumber, 1); >- my $marcnotesarray = GetMarcNotes( $record, $marcflavour ); > my $marcauthorsarray = GetMarcAuthors( $record, $marcflavour ); > my $marcsubjctsarray = GetMarcSubjects( $record, $marcflavour ); > my $subtitle = GetRecordValue( 'subtitle', $record, $fw ); >@@ -89,7 +88,6 @@ if ($email) { > my @items = GetItemsInfo($biblionumber); > > $dat->{ISBN} = GetMarcISBN($record, $marcflavour); >- $dat->{MARCNOTES} = $marcnotesarray; > $dat->{MARCSUBJCTS} = $marcsubjctsarray; > $dat->{MARCAUTHORS} = $marcauthorsarray; > $dat->{'biblionumber'} = $biblionumber; >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14306
:
39737
|
39741
|
41237
|
41987
|
41995
|
42010
|
42011
|
42012
|
42013
|
46221
|
46251
|
46252
|
46253
|
46254
|
48681
|
48682
|
48683
| 48684