Attachment 48701 Details for Bug 15982 – Bug 15982 - Serials numbering patterns can be deleted without warning

[patch] Bug 15982 - Serials numbering patterns can be deleted without warning

Bug-15982---Serials-numbering-patterns-can-be-dele.patch (text/plain), 2.35 KB, created by Owen Leonard on 2016-03-04 17:09:34 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Owen Leonard

Created: 2016-03-04 17:09:34 UTC

Size: 2.35 KB

patch

obsolete

>From 5c35d01fd001c40216da279f14052ef9662c4552 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Fri, 4 Mar 2016 12:07:44 -0500
>Subject: [PATCH] Bug 15982 - Serials numbering patterns can be deleted without
> warning
>Content-Type: text/plain; charset="utf-8"
>
>A JavaScript alert should ask the user to confirm deletion of a serial
>numbering pattern. This patch adds this to the template.
>
>To test, apply the patch and go to Serials -> Manage numbering patterns.
>
>- In the list of patterns, click any "Delete" link.
>- Verify that a JavaScript alert is triggered.
>- Test that cancelling the alert cancels the deletion operation.
>- Test that confirming the alert allows the deletion to complete.
>---
> .../prog/en/modules/serials/subscription-numberpatterns.tt   | 12 +++++++++++-
> 1 file changed, 11 insertions(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-numberpatterns.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-numberpatterns.tt
>index e0c56fe..07c1f0d 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-numberpatterns.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-numberpatterns.tt
>@@ -4,6 +4,11 @@
> [% INCLUDE 'calendar.inc' %]
> <script type="text/javascript">
> //<![CDATA[
>+
>+function confirmDelete() {
>+  return confirm(_("Are you sure you want to delete this numbering pattern?"));
>+}
>+
> [% IF (new or modify) %]
>   function testPattern() {
>       var frequencyid = $("#frequency").val();
>@@ -57,6 +62,11 @@
> function show_blocking_subs() {
>     $("#blocking_subs").show();
> }
>+$(document).ready(function(){
>+    $(".delete_pattern").on("click",function(){
>+        return confirmDelete();
>+    });
>+});
> //]]>
> </script>
> </head>
>@@ -318,7 +328,7 @@ function show_blocking_subs() {
>                   <td>[% numberpattern.displayorder %]</td>
>                   <td>
>                     <a href="/cgi-bin/koha/serials/subscription-numberpatterns.pl?op=modify&id=[% numberpattern.id %]">Edit</a> |
>-                    <a href="/cgi-bin/koha/serials/subscription-numberpatterns.pl?op=del&id=[% numberpattern.id %]">Delete</a>
>+                    <a class="delete_pattern" href="/cgi-bin/koha/serials/subscription-numberpatterns.pl?op=del&id=[% numberpattern.id %]">Delete</a>
>                   </td>
>                 </tr>
>               [% END %]
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 15982: 48701 | 48818 | 48843