Bugzilla – Attachment 48772 Details for
Bug 15084
Move the currency related code to Koha::Acquisition::Currenc[y|ies]
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 15084: typo currency vs currency_code
Bug-15084-typo-currency-vs-currencycode.patch (text/plain), 2.06 KB, created by
Jonathan Druart
on 2016-03-08 10:19:34 UTC
(
hide
)
Description:
Bug 15084: typo currency vs currency_code
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2016-03-08 10:19:34 UTC
Size:
2.06 KB
patch
obsolete
>From 8ed176e3573df86dbe4da1f4f1a91f6229452c29 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 8 Mar 2016 10:15:32 +0000 >Subject: [PATCH] Bug 15084: typo currency vs currency_code > >The DB column is currency.currency not currency.currency_code. > >Test plan: >Delete a currency >Without this patch, you will get a warning in the logs: >No method currency_code! at >/home/koha/src/koha-tmpl/intranet-tmpl/prog/en/modules/admin/currency.tt >line 148. >And the currency won't be deleted. > >With this patch, it will! > >It also changes the value of the delete op. >--- > admin/currency.pl | 2 +- > koha-tmpl/intranet-tmpl/prog/en/modules/admin/currency.tt | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > >diff --git a/admin/currency.pl b/admin/currency.pl >index 9c8f825..4d791db 100755 >--- a/admin/currency.pl >+++ b/admin/currency.pl >@@ -98,7 +98,7 @@ if ( $op eq 'add_form' ) { > currency => $currency, > nb_of_orders => $nb_of_orders, > ); >-} elsif ( $op eq 'delete' ) { >+} elsif ( $op eq 'delete_confirmed' ) { > my $currency = Koha::Acquisition::Currencies->find($currency_code); > my $deleted = eval { $currency->delete; }; > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/currency.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/currency.tt >index 305e471..8fb7152 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/currency.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/currency.tt >@@ -145,7 +145,7 @@ > </table> > <form action="/cgi-bin/koha/admin/currency.pl" method="post"> > <input type="hidden" name="op" value="delete_confirmed" /> >- <input type="hidden" name="currency_code" value="[% currency.currency_code %]" /> >+ <input type="hidden" name="currency_code" value="[% currency.currency %]" /> > <button type="submit" class="approve"><i class="fa fa-fw fa-check"></i> Yes, delete this currency</button> > </form> > <form action="/cgi-bin/koha/admin/currency.pl" method="post"> >-- >2.7.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 15084
:
44162
|
44163
|
44164
|
44165
|
44166
|
44167
|
44168
|
45690
|
45691
|
45692
|
45693
|
45694
|
45695
|
45696
|
45759
|
45761
|
45807
|
45808
|
45809
|
45810
|
45811
|
45812
|
45813
|
45814
|
47213
|
47214
|
47215
|
47216
|
47217
|
47218
|
47219
|
47220
|
47221
|
48594
|
48595
|
48596
|
48597
|
48598
|
48599
|
48600
|
48601
|
48602
|
48603
|
48703
|
48747
| 48772 |
48783
|
48858