Bugzilla – Attachment 48816 Details for
Bug 15979
Use Font Awesome icons subscription deletion confirmation dialog
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 15979 - Use Font Awesome icons subscription deletion confirmation dialog
Bug-15979---Use-Font-Awesome-icons-subscription-de.patch (text/plain), 2.64 KB, created by
Nicole C. Engard
on 2016-03-08 20:33:53 UTC
(
hide
)
Description:
Bug 15979 - Use Font Awesome icons subscription deletion confirmation dialog
Filename:
MIME Type:
Creator:
Nicole C. Engard
Created:
2016-03-08 20:33:53 UTC
Size:
2.64 KB
patch
obsolete
>From d239aa7a38e9bc9e1c5362d5fa719262198216ea Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Fri, 4 Mar 2016 11:17:50 -0500 >Subject: [PATCH] Bug 15979 - Use Font Awesome icons subscription deletion > confirmation dialog > >When deleting a subscription which has not expired or which has linked >issues or items, a dialog asks for confirmation. This patch updates the >dialog to use Font Awesome icons. > >Other minor change: Corrected capitalization in dialog heading. > >To test, apply the patch and go to Serials. > >- Locate a subscription which can be deleted and which has not expired, > has linked items, or has linked issues. >- View the detail page for that subscription. >- Choose "Delete subscription" from the "Edit" menu. >- Verify that the confirmation dialog is correctly styled. >- Verify that the "No, don't delete" button works correctly. >- Verify that the "Yes, delete" button deletes the subscription. > >Signed-off-by: Nicole C Engard <nengard@bywatersolutions.com> >--- > .../intranet-tmpl/prog/en/modules/serials/subscription-detail.tt | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt >index dc0e246..858f41a 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt >@@ -50,7 +50,7 @@ $(document).ready(function() { > [% END %] > [% IF ( NEEDSCONFIRMATION ) %] > <div id="circ_needsconfirmation" class="dialog alert"> >- <h3>Please Confirm Subscription deletion</h3> >+ <h3>Please confirm subscription deletion</h3> > > <ul> > [% IF ( NOTEXPIRED ) %] <li>The subscription has not expired yet</li> [% END %] >@@ -61,11 +61,11 @@ $(document).ready(function() { > <input type="hidden" name="subscriptionid" value="[% subscriptionid %]" /> > <input type="hidden" name="issueconfirmed" value="1" /> > <input type="hidden" name="op" value="del" /> >- <input type="submit" class="approve" value="Yes, delete (Y)" accesskey="y" /> >+ <button type="submit" class="approve" accesskey="y"><i class="fa fa-fw fa-check"></i> Yes, delete (Y)</button> > </form> > <form method="get" action="/cgi-bin/koha/serials/subscription-detail.pl"> > <input type="hidden" name="subscriptionid" value="[% subscriptionid %]" /> >- <input type="submit" class="deny" value="No, don't delete (N)" accesskey="n" /> >+ <button type="submit" class="deny" accesskey="n"><i class="fa fa-fw fa-remove"></i> No, don't delete (N)</button> > </form> > > </div> >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 15979
:
48697
|
48816
|
48841