Attachment 48842 Details for Bug 15981 – Bug 15981 - Serials frequencies can be deleted without warning

[patch] Bug 15981 - Serials frequencies can be deleted without warning

Bug-15981---Serials-frequencies-can-be-deleted-wit.patch (text/plain), 2.09 KB, created by Jonathan Druart on 2016-03-09 11:03:29 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2016-03-09 11:03:29 UTC

Size: 2.09 KB

patch

obsolete

>From b33e07c5ebe8801ed0532c236d0f73800d8a16a1 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Fri, 4 Mar 2016 11:52:25 -0500
>Subject: [PATCH] Bug 15981 - Serials frequencies can be deleted without
> warning
>
>A JavaScript alert should ask the user to confirm deletion of a serial
>frequency. This patch adds this to the template.
>
>To test, apply the patch and go to Serials -> Manage frequencies
>
>- In the list of frequencies, click any "Delete" link.
>- Verify that a JavaScript alert is triggered.
>- Test that cancelling the alert cancels the deletion operation.
>- Test that confirming the alert allows the deletion to complete.
>
>Signed-off-by: Nicole C Engard <nengard@bywatersolutions.com>
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> .../prog/en/modules/serials/subscription-frequencies.tt              | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-frequencies.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-frequencies.tt
>index 8442ed2..5ffbbce 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-frequencies.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-frequencies.tt
>@@ -61,6 +61,9 @@ $(document).ready(function() {
>             $("#issuesperunit").val(1);
>         }
>     });
>+    $(".delete_frequency").on("click",function(){
>+        return confirmDelete();
>+    });
> });
> //]]>
> </script>
>@@ -208,7 +211,7 @@ $(document).ready(function() {
>                   <td>[% frequency.displayorder %]</td>
>                   <td>
>                     <a href="/cgi-bin/koha/serials/subscription-frequencies.pl?op=modify&frequencyid=[% frequency.id %]">Modify</a> |
>-                    <a href="/cgi-bin/koha/serials/subscription-frequencies.pl?op=del&frequencyid=[% frequency.id %]">Delete</a>
>+                    <a class="delete_frequency" href="/cgi-bin/koha/serials/subscription-frequencies.pl?op=del&frequencyid=[% frequency.id %]">Delete</a>
>                   </td>
>                 </tr>
>               [% END %]
>-- 
>2.7.0

Actions: View | Diff | Splinter Review

Attachments on bug 15981: 48699 | 48817 | 48842