Attachment 4886 Details for Bug 6679 – Bug 6679 : acqui/ now passes Perl::Critic tests

[patch] Bug 6679 : acqui/ now passes Perl::Critic tests

Bug-6679--acqui-now-passes-PerlCritic-tests.patch (text/plain), 1.61 KB, created by Chris Cormack on 2011-08-08 09:04:50 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Cormack

Created: 2011-08-08 09:04:50 UTC

Size: 1.61 KB

patch

obsolete

>From 044e4a49f0b823da9d6d60e9181a0aa96304e789 Mon Sep 17 00:00:00 2001
>From: Chris Cormack <chrisc@catalyst.net.nz>
>Date: Mon, 8 Aug 2011 21:04:08 +1200
>Subject: [PATCH] Bug 6679 : acqui/ now passes Perl::Critic tests
>
>---
> acqui/neworderempty.pl |    3 ++-
> t/00-testcritic.t      |    2 +-
> 2 files changed, 3 insertions(+), 2 deletions(-)
>
>diff --git a/acqui/neworderempty.pl b/acqui/neworderempty.pl
>index c7d6083..05968c6 100755
>--- a/acqui/neworderempty.pl
>+++ b/acqui/neworderempty.pl
>@@ -330,7 +330,8 @@ if (C4::Context->preference('AcqCreateItem') eq 'ordering' && !$ordernumber) {
>     $template->param(items => \@itemloop);
> }
> # Get the item types list, but only if item_level_itype is YES. Otherwise, it will be in the item, no need to display it in the biblio
>-my @itemtypes = C4::ItemType->all unless C4::Context->preference('item-level_itypes');
>+my @itemtypes;
>+@itemtypes = C4::ItemType->all unless C4::Context->preference('item-level_itypes');
> 
> # fill template
> $template->param(
>diff --git a/t/00-testcritic.t b/t/00-testcritic.t
>index 65f2288..4a285b3 100755
>--- a/t/00-testcritic.t
>+++ b/t/00-testcritic.t
>@@ -16,7 +16,7 @@ my @all_koha_dirs = qw( acqui admin authorities basket C4 catalogue cataloguing
> labels members misc offline_circ opac patroncards reports reserve reviews rotating_collections
> serials sms suggestion t tags test tools virtualshelves);
> 
>-my @dirs = qw( basket circ debian errors offline_circ reserve reviews rotating_collections
>+my @dirs = qw( acqui basket circ debian errors offline_circ reserve reviews rotating_collections
> serials sms virtualshelves );
> 
> if ( not $ENV{TEST_QA} ) {
>-- 
>1.7.4.1

Actions: View | Diff | Splinter Review

Attachments on bug 6679: 4883 | 4884 | 4885 | 4886 | 4887 | 4888 | 5445 | 5446 | 5483 | 5487 | 6121 | 6122 | 6123 | 6139 | 6140 | 6141 | 6142 | 6143 | 6144 | 6270 | 6271 | 6663 | 6670 | 6675 | 6676 | 6677 | 6678 | 8542 | 8897 | 8898 | 8899 | 8950 | 8951 | 9746 | 9747 | 9748 | 9749 | 9750 | 10050 | 10051 | 10052 | 10053 | 10054 | 10075 | 10076 | 10077 | 10078 | 10079 | 10484 | 10485 | 10486 | 10487 | 10488 | 10489 | 10491 | 10492 | 10493 | 10494 | 10495 | 10496 | 10497 | 10499 | 10500 | 10501 | 10502 | 10503 | 10504 | 10505 | 10506 | 10507 | 10508 | 10509 | 10510 | 10512 | 10513 | 10514 | 10515 | 10517 | 10521 | 10522 | 10523 | 10524 | 10525 | 10526 | 10527 | 10935 | 10936 | 10938 | 10940 | 10944 | 10945 | 10946 | 10947 | 10948 | 10949 | 10950 | 10952 | 10953 | 10955 | 10957 | 10958 | 10959 | 10960 | 10961 | 10962 | 10963 | 10964 | 10965 | 10966 | 10967 | 10972 | 10976 | 10979 | 10980 | 10981 | 12224 | 12363 | 12490 | 12491 | 12492 | 34191 | 34192 | 34193 | 34194 | 34195 | 34196 | 34197 | 39100 | 39101 | 39102 | 39392 | 39393 | 39394 | 39395 | 39396 | 39397 | 39398 | 42770 | 47086 | 47087 | 47088 | 47089 | 47090 | 47178 | 47179 | 47180 | 47181 | 47205 | 47206 | 47207 | 47208