Bugzilla – Attachment 48897 Details for
Bug 16031
sitemap.pl shouldn't append protocol to OPACBaseURL
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Bug 16031: sitemap.pl shouldn't append protocol to OPACBaseURL
SIGNED-OFF-Bug-16031-sitemappl-shouldnt-append-pro.patch (text/plain), 1.30 KB, created by
Mark Tompsett
on 2016-03-09 20:08:13 UTC
(
hide
)
Description:
[SIGNED-OFF] Bug 16031: sitemap.pl shouldn't append protocol to OPACBaseURL
Filename:
MIME Type:
Creator:
Mark Tompsett
Created:
2016-03-09 20:08:13 UTC
Size:
1.30 KB
patch
obsolete
>From ffbf5b971f044fb4e7f0c0dba59b400a6b374324 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Wed, 9 Mar 2016 15:41:02 -0300 >Subject: [PATCH] [SIGNED-OFF] Bug 16031: sitemap.pl shouldn't append protocol > to OPACBaseURL > >Since bug 5010 was pushed, OPACBaseURL already contains the protocol. The >sitemap.pl script was written before this was pushed, and thus still concatenates >http:// in front of OPACBaseURL. > >This patch removes this behaviour. > >To test: >- Have OPACBaseURL set to (say) http://myopac.com >- Run the sitemap.pl script without specifying the --url param >=> FAIL: Notice URLs look like http://http://myopac.com/bib... in the sitemap files. >- Apply the patch >- Run the sitemap.pl script without specifying the --url param >=> SUCCESS: Notice URLs look correctly like http://myopac.com/bib... >- Sign off :-D > >Regards > >Signed-off-by: Mark Tompsett <mtompset@hotmail.com> >--- > misc/cronjobs/sitemap.pl | 1 - > 1 file changed, 1 deletion(-) > >diff --git a/misc/cronjobs/sitemap.pl b/misc/cronjobs/sitemap.pl >index 0d61531..bc1bca7 100755 >--- a/misc/cronjobs/sitemap.pl >+++ b/misc/cronjobs/sitemap.pl >@@ -49,7 +49,6 @@ unless ($url) { > say "OPACBaseURL syspref isn't defined. You can use --url parameter."; > exit; > } >- $url = 'http://' . $url; > } > $url =~ s/\/*$//g; > >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 16031
:
48893
|
48894
|
48897
|
48898
|
48952
|
48953