Attachment 49007 Details for Bug 16048 – [SIGNED-OFF] Bug 16048: Making notices actions buttons

[patch] [SIGNED-OFF] Bug 16048: Making notices actions buttons

SIGNED-OFF-Bug-16048-Making-notices-actions-button.patch (text/plain), 2.90 KB, created by Owen Leonard on 2016-03-11 13:11:48 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Owen Leonard

Created: 2016-03-11 13:11:48 UTC

Size: 2.90 KB

patch

obsolete

>From 3be345032296c179ad4888f1373bcaa88265c27e Mon Sep 17 00:00:00 2001
>From: Aleisha <aleishaamohia@hotmail.com>
>Date: Thu, 10 Mar 2016 22:45:25 +0000
>Subject: [PATCH] [SIGNED-OFF] Bug 16048: Making notices actions buttons
>Content-Type: text/plain; charset="utf-8"
>
>EDIT: Adding no wrap class to Actions column for when libraries with longer names mess up formatting
>
>To test:
>1) Go to Tools -> Notices and slips (tools/letter.pl)
>2) Confirm that all actions (Copy, Edit and Delete) now show as font awesome buttons and work as expected
>
>Sponsored-by: Catalyst IT
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>
>I have a couple of corrections in a follow-up.
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt | 13 +++++--------
> 1 file changed, 5 insertions(+), 8 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt
>index 1f7ad2b..91f6f10 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt
>@@ -200,8 +200,7 @@ $(document).ready(function() {
>                 <th>Code</th>
>                 <th>Name</th>
>                 <th>Copy notice</th>
>-                <th>&nbsp;</th>
>-                <th>&nbsp;</th>
>+                <th>Actions</th>
>               </tr>
>             </thead>
>             <tbody>
>@@ -224,18 +223,16 @@ $(document).ready(function() {
>                         [% ELSE %]
>                           [% select_for_copy %]
>                         [% END %]
>-                        <input type="submit" value="Copy" />
>+                        <button class="btn btn-mini"><i class="fa fa-clone"></i> Copy</button>
>                       </form>
>                     [% END %]
>                   </td>
>-                  <td>
>+                  <td style="white-space: nowrap">
>                     [% IF can_edit %]
>-                      <a href="/cgi-bin/koha/tools/letter.pl?op=add_form&amp;branchcode=[% lette.branchcode %]&amp;module=[% lette.module %]&amp;code=[% lette.code %]">Edit</a>
>+                      <a class="btn btn-mini" href="/cgi-bin/koha/tools/letter.pl?op=add_form&amp;branchcode=[% lette.branchcode %]&amp;module=[% lette.module %]&amp;code=[% lette.code %]"><i class="fa fa-pencil"></i> Edit</a>
>                     [% END %]
>-                  </td>
>-                  <td>
>                     [% IF !lette.protected && can_edit %]
>-                      <a href="/cgi-bin/koha/tools/letter.pl?op=delete_confirm&amp;branchcode=[%lette.branchcode %]&amp;module=[% lette.module %]&amp;code=[% lette.code %]">Delete</a>
>+                      <a class="btn btn-mini" href="/cgi-bin/koha/tools/letter.pl?op=delete_confirm&amp;branchcode=[%lette.branchcode %]&amp;module=[% lette.module %]&amp;code=[% lette.code %]"><i class="fa fa-trash"></i> Delete</a>
>                     [% END %]
>                   </td>
>                 </tr>
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 16048: 48979 | 48980 | 49007 | 49008 | 49010 | 49011