Bugzilla – Attachment 49082 Details for
Bug 15921
DataTables JavaScript files included twice on many pages
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Bug 15921: Do not include datatables js/css files twice
SIGNED-OFF-Bug-15921-Do-not-include-datatables-jsc.patch (text/plain), 1.47 KB, created by
Srdjan Jankovic
on 2016-03-14 02:58:19 UTC
(
hide
)
Description:
[SIGNED-OFF] Bug 15921: Do not include datatables js/css files twice
Filename:
MIME Type:
Creator:
Srdjan Jankovic
Created:
2016-03-14 02:58:19 UTC
Size:
1.47 KB
patch
obsolete
>From aac24ef719cf46a61fc60d16973ca5ae006c4870 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Mon, 29 Feb 2016 08:55:36 +0000 >Subject: [PATCH] [SIGNED-OFF] Bug 15921: Do not include datatables js/css > files twice > >datatables.inc loads dataTables.buttons.min.js and buttons.colVis.min.js >since bug 15285: Update common files because the dom param now contains >'B'. The DT init fails with it does not know what 'B' means. > >Test plan: >Test tables using buttons (columns visibility), they should work as >before this patch. > >Signed-off-by: Srdjan <srdjan@catalyst.net.nz> >--- > koha-tmpl/intranet-tmpl/prog/en/includes/columns_settings.inc | 4 ---- > 1 file changed, 4 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/columns_settings.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/columns_settings.inc >index 3fed1bc..b065a35 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/columns_settings.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/columns_settings.inc >@@ -1,9 +1,5 @@ > [% USE ColumnsSettings %] > >-<link rel="stylesheet" type="text/css" href="[% themelang %]/css/buttons.dataTables.min.css" /> >-<script type="text/javascript" src="[% interface %]/lib/jquery/plugins/dataTables.buttons.min.js"></script> >-<script type="text/javascript" src="[% interface %]/lib/jquery/plugins/buttons.colVis.min.js"></script> >- > <script type="text/javascript"> > function KohaTable(selector, dt_parameters, columns_settings) { > var id = 0; >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 15921
:
48433
|
49082
|
49386
|
49433
|
49481