Attachment 49196 Details for Bug 16070 – [SIGNED-OFF] Bug 16070: Default value for sysprefs should be an empty string

[patch] [SIGNED-OFF] Bug 16070: Default value for sysprefs should be an empty string

Bug-16070-Default-value-for-sysprefs-should-be-an-.patch (text/plain), 10.58 KB, created by Srdjan Jankovic on 2016-03-16 04:57:02 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Srdjan Jankovic

Created: 2016-03-16 04:57:02 UTC

Size: 10.58 KB

patch

obsolete

>From d2d2a56b0c655a2d21f95a0ec6ab7d2703b413c3 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Tue, 15 Mar 2016 10:05:06 +0000
>Subject: [PATCH] Bug 16070: Default value for sysprefs should be an empty
> string
>
>The default value for sysprefs should not be NULL but an empty string.
>When a pref is cleared, it's set to an empty string, so it does not make
>sense to create it with an undefined value.
>
>The main purpose of this patch is to remove the warning in logs when a
>pref is accessed for the first time and the cache is not yet populated.
>It also ensures that the behavior will be the same for the first access
>and the others.
>
>Test plan:
>SELECT COUNT(*) FROM systempreferences WHERE value IS NULL;
>Should not return any results after the update DB entry executed.
>
>Signed-off-by: Srdjan <srdjan@catalyst.net.nz>
>---
> installer/data/mysql/sysprefs.sql | 24 ++++++++++++------------
> 1 file changed, 12 insertions(+), 12 deletions(-)
>
>diff --git a/installer/data/mysql/sysprefs.sql b/installer/data/mysql/sysprefs.sql
>index e2e3ad2..79cf51e 100644
>--- a/installer/data/mysql/sysprefs.sql
>+++ b/installer/data/mysql/sysprefs.sql
>@@ -95,8 +95,8 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, `
> ('CircControl','ItemHomeLibrary','PickupLibrary|PatronLibrary|ItemHomeLibrary','Specify the agency that controls the circulation and fines policy','Choice'),
> ('ClaimsBccCopy','0','','Bcc the ClaimAcquisition and ClaimIssues alerts','YesNo'),
> ('Coce','0', NULL, 'If on, enables cover retrieval from the configured Coce server', 'YesNo'),
>-('CoceHost', NULL, NULL, 'Coce server URL', 'Free'),
>-('CoceProviders', NULL, 'aws,gb,ol', 'Coce providers', 'multiple'),
>+('CoceHost', '', NULL, 'Coce server URL', 'Free'),
>+('CoceProviders', '', 'aws,gb,ol', 'Coce providers', 'multiple'),
> ('COinSinOPACResults','1','','If ON, use COinS in OPAC search results page.  NOTE: this can slow down search response time significantly','YesNo'),
> ('ConfirmFutureHolds','0','','Number of days for confirming future holds','Integer'),
> ('ConsiderOnSiteCheckoutsAsNormalCheckouts','1',NULL,'Consider on-site checkouts as normal checkouts','YesNo'),
>@@ -111,9 +111,9 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, `
> ('decreaseLoanHighHoldsValue',NULL,'','Specifies a threshold for the minimum number of holds needed to trigger a reduction in loan duration (used with decreaseLoanHighHolds)','Integer'),
> ('DefaultClassificationSource','ddc',NULL,'Default classification scheme used by the collection. E.g., Dewey, LCC, etc.','ClassSources'),
> ('DefaultLanguageField008','','','Fill in the default language for field 008 Range 35-37 of MARC21 records (e.g. eng, nor, ger, see <a href=\"http://www.loc.gov/marc/languages/language_code.html\">MARC Code List for Languages</a>)','Free'),
>-('DefaultLongOverdueChargeValue', NULL, NULL, "Charge a lost item to the borrower's account when the LOST value of the item changes to n.", 'integer'),
>-('DefaultLongOverdueDays', NULL, NULL, "Set the LOST value of an item when the item has been overdue for more than n days.", 'integer'),
>-('DefaultLongOverdueLostValue', NULL, NULL, "Set the LOST value of an item to n when the item has been overdue for more than defaultlongoverduedays days.", 'integer'),
>+('DefaultLongOverdueChargeValue', '', NULL, "Charge a lost item to the borrower's account when the LOST value of the item changes to n.", 'integer'),
>+('DefaultLongOverdueDays', '', NULL, "Set the LOST value of an item when the item has been overdue for more than n days.", 'integer'),
>+('DefaultLongOverdueLostValue', '', NULL, "Set the LOST value of an item to n when the item has been overdue for more than defaultlongoverduedays days.", 'integer'),
> ('defaultSortField','relevance','relevance|popularity|call_number|pubdate|acqdate|title|author','Specify the default field used for sorting','Choice'),
> ('defaultSortOrder','dsc','asc|dsc|az|za','Specify the default sort order','Choice'),
> ('DefaultToLoggedInLibraryCircRules',  '0', NULL ,  'If enabled, circ rules editor will default to the logged in library''s rules, rather than the ''all libraries'' rules.',  'YesNo'),
>@@ -180,7 +180,7 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, `
> ('OnSiteCheckouts','0','','Enable/Disable the on-site checkouts feature','YesNo'),
> ('OnSiteCheckoutsForce','0','','Enable/Disable the on-site for all cases (Even if a user is debarred, etc.)','YesNo'),
> ('InProcessingToShelvingCart','0','','If set, when any item with a location code of PROC is \'checked in\', it\'s location code will be changed to CART.','YesNo'),
>-('INTRAdidyoumean',NULL,NULL,'Did you mean? configuration for the Intranet. Do not change, as this is controlled by /cgi-bin/koha/admin/didyoumean.pl.','Free'),
>+('INTRAdidyoumean','',NULL,'Did you mean? configuration for the Intranet. Do not change, as this is controlled by /cgi-bin/koha/admin/didyoumean.pl.','Free'),
> ('IntranetBiblioDefaultView','normal','normal|marc|isbd|labeled_marc','Choose the default detail view in the staff interface; choose between normal, labeled_marc, marc or isbd','Choice'),
> ('intranetbookbag','1','','If ON, enables display of Cart feature in the intranet','YesNo'),
> ('intranetcolorstylesheet','','50','Define the color stylesheet to use in the Staff Client','free'),
>@@ -229,7 +229,7 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, `
> ('maxRecordsForFacets','20',NULL,NULL,'Integer'),
> ('maxreserves','50','','Define maximum number of holds a patron can place','Integer'),
> ('MaxSearchResultsItemsPerRecordStatusCheck','20','','Max number of items per record for which to check transit and hold status','Integer'),
>-('MembershipExpiryDaysNotice',NULL,'Send an account expiration notice that a patron\'s card is about to expire after',NULL,'Integer'),
>+('MembershipExpiryDaysNotice','',NULL,'Send an account expiration notice that a patron\'s card is about to expire after','Integer'),
> ('MergeReportFields','',NULL,'Displayed fields for deleted MARC records after merge','Free'),
> ('minPasswordLength','3',NULL,'Specify the minimum length of a patron/staff password','free'),
> ('NewItemsDefaultLocation','','','If set, all new items will have a location of the given Location Code ( Authorized Value type LOC )',''),
>@@ -247,8 +247,8 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, `
> ('NoticeCSS','',NULL,'Notices CSS url.','free'),
> ('NotifyBorrowerDeparture','30',NULL,'Define number of days before expiry where circulation is warned about patron account expiry','Integer'),
> ('NovelistSelectEnabled','0',NULL,'Enable Novelist Select content.  Requires Novelist Profile and Password','YesNo'),
>-('NovelistSelectPassword',NULL,NULL,'Enable Novelist user Profile','free'),
>-('NovelistSelectProfile',NULL,NULL,'Novelist Select user Password','free'),
>+('NovelistSelectPassword','',NULL,'Enable Novelist user Profile','free'),
>+('NovelistSelectProfile','',NULL,'Novelist Select user Password','free'),
> ('NovelistSelectView','tab','tab|above|below|right','Where to display Novelist Select content','Choice'),
> ('numReturnedItemsToShow','20',NULL,'Number of returned items to show on the check-in page','Integer'),
> ('numSearchResults','20',NULL,'Specify the maximum number of results to display on a page of results','Integer'),
>@@ -270,7 +270,7 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, `
> ('OPACAllowUserToChooseBranch','1','1','Allow the user to choose the branch they want to pickup their hold from','YesNo'),
> ('OPACAmazonCoverImages','0','','Display cover images on OPAC from Amazon Web Services','YesNo'),
> ('OpacAuthorities','1',NULL,'If ON, enables the search authorities link on OPAC','YesNo'),
>-('OPACBaseURL',NULL,NULL,'Specify the Base URL of the OPAC, e.g., http://opac.mylibrary.com, including the protocol (http:// or https://). Otherwise, the http:// will be added automatically by Koha upon saving.','Free'),
>+('OPACBaseURL','',NULL,'Specify the Base URL of the OPAC, e.g., http://opac.mylibrary.com, including the protocol (http:// or https://). Otherwise, the http:// will be added automatically by Koha upon saving.','Free'),
> ('opacbookbag','1','','If ON, enables display of Cart feature','YesNo'),
> ('OpacBrowser','0',NULL,'If ON, enables subject authorities browser on OPAC (needs to set misc/cronjob/sbuild_browser_and_cloud.pl)','YesNo'),
> ('OpacBrowseResults','1',NULL,'Disable/enable browsing and paging search results from the OPAC detail page.','YesNo'),
>@@ -280,7 +280,7 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, `
> ('opaccredits','','70|10','Define HTML Credits at the bottom of the OPAC page','Textarea'),
> ('OPACdefaultSortField','relevance','relevance|popularity|call_number|pubdate|acqdate|title|author','Specify the default field used for sorting','Choice'),
> ('OPACdefaultSortOrder','dsc','asc|dsc|za|az','Specify the default sort order','Choice'),
>-('OPACdidyoumean',NULL,NULL,'Did you mean? configuration for the OPAC. Do not change, as this is controlled by /cgi-bin/koha/admin/didyoumean.pl.','Free'),
>+('OPACdidyoumean','',NULL,'Did you mean? configuration for the OPAC. Do not change, as this is controlled by /cgi-bin/koha/admin/didyoumean.pl.','Free'),
> ('OPACDisplay856uAsImage','OFF','OFF|Details|Results|Both','Display the URI in the 856u field as an image, the corresponding OPACXSLT option must be on','Choice'),
> ('OpacExportOptions','bibtex,dc,marcxml,marc8,utf8,marcstd,mods,ris,isbd','','Define export options available on OPAC detail page.','multiple'),
> ('OPACFallback', 'prog', 'bootstrap|prog', 'Define the fallback theme for the OPAC interface.', 'Themes'),
>@@ -470,7 +470,7 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, `
> ('SyndeticsSummary','0','','Display Summary Information from Syndetics','YesNo'),
> ('SyndeticsTOC','0','','Display Table of Content information from Syndetics','YesNo'),
> ('TagsEnabled','1','','Enables or disables all tagging features.  This is the main switch for tags.','YesNo'),
>-('TagsExternalDictionary',NULL,'','Path on server to local ispell executable, used to set $Lingua::Ispell::path  This dictionary is used as a \"whitelist\" of pre-allowed tags.',''),
>+('TagsExternalDictionary','','','Path on server to local ispell executable, used to set $Lingua::Ispell::path  This dictionary is used as a \"whitelist\" of pre-allowed tags.',''),
> ('TagsInputOnDetail','1','','Allow users to input tags from the detail page.','YesNo'),
> ('TagsInputOnList','0','','Allow users to input tags from the search results list.','YesNo'),
> ('TagsModeration','0','','Require tags from patrons to be approved before becoming visible.','YesNo'),
>-- 
>1.9.1

Actions: View | Diff | Splinter Review

Attachments on bug 16070: 49164 | 49196 | 49254 | 49550 | 49551