Attachment 49243 Details for Bug 16059 – Bug 16059: Use Font Awesome icons in standard cataloging duplicate warning dialog

[patch] Bug 16059: Use Font Awesome icons in standard cataloging duplicate warning dialog

Bug-16059-Use-Font-Awesome-icons-in-standard-catal.patch (text/plain), 4.25 KB, created by Jonathan Druart on 2016-03-17 08:53:41 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2016-03-17 08:53:41 UTC

Size: 4.25 KB

patch

obsolete

>From df8c07fca5465f654b57402e477eeda252714097 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Tue, 8 Mar 2016 21:08:01 -0500
>Subject: [PATCH] Bug 16059: Use Font Awesome icons in standard cataloging
> duplicate warning dialog
>
>In the standard MARC editor, when a duplicate record is suspected a
>dialog is shown. This patch updates the template to show Font Awesome
>icons in this dialog.
>
>Also changed: Using <h3> instead of <h4> in dialog so that it is
>correctly styled. Adding "popup" class to duplicate record link to
>indicate that a new window will be opened.
>
>To test, apply the patch and go to Cataloging -> New record.
>
>- Use Z39.50 to import a record which is already in your catalog.
>- Save the record. Confirm that the duplicate warning dialog is styled
>  correctly.
>- Confirm that both the "Save as new" and "Edit items" buttons work
>  correctly.
>
>Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
>Works as advertised
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt
>index 0d31c4b..09342b3 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt
>@@ -410,17 +410,17 @@ function Changefwk(FwkList) {
>     
>         [% IF ( duplicatebiblionumber ) %]
>                     <div class="dialog alert">
>-                        <h4>Duplicate record suspected</h4>
>-                        <p>Is this a duplicate of <a href="/cgi-bin/koha/catalogue/MARCdetail.pl?biblionumber=[% duplicatebiblionumber %]" onclick="openWindow('/cgi-bin/koha/catalogue/MARCdetail.pl?biblionumber=[% duplicatebiblionumber %]&amp;popup=1', 'DuplicateBiblio','800','600'); return false;">[% duplicatetitle %]</a>?</p>
>+                        <h3>Duplicate record suspected</h3>
>+                        <p>Is this a duplicate of <a class="popup" href="/cgi-bin/koha/catalogue/MARCdetail.pl?biblionumber=[% duplicatebiblionumber %]" onclick="openWindow('/cgi-bin/koha/catalogue/MARCdetail.pl?biblionumber=[% duplicatebiblionumber %]&amp;popup=1', 'DuplicateBiblio','800','600'); return false;">[% duplicatetitle %]</a> ?</p>
>                         [% IF ( CAN_user_editcatalogue_edit_items ) %]<form action="/cgi-bin/koha/cataloguing/additem.pl" method="get">
>                                                     <input type="hidden" name="biblionumber" value="[% duplicatebiblionumber %]" />
>-                                                    <input type="submit" class="edit" value="Yes: Edit existing items" />
>+                                                    <button type="submit" class="new"><i class="fa fa-fw fa-pencil"></i> Yes, edit existing items</button>
>                                                 </form>[% ELSE %]<form action="/cgi-bin/koha/catalogue/detail.pl" method="get">
>                                                     <input type="hidden" name="biblionumber" value="[% duplicatebiblionumber %]" />
>                                                     <input type="submit" value="Yes: View existing items" />
>                                                 </form>[% END %]
>                         <form action="/cgi-bin/koha/cataloguing/addbiblio.pl" method="get">
>-                        [% IF ( CAN_user_editcatalogue_edit_items ) %]<input type="button" class="save" onclick="confirmnotdup('items'); return false;" value="No: Save as new record" />[% ELSE %]<input type="button" class="save" onclick="confirmnotdup('view'); return false;" value="No: Save as new record" />[% END %]
>+                            [% IF ( CAN_user_editcatalogue_edit_items ) %]<button type="submit" class="new" onclick="confirmnotdup('items'); return false;"><i class="fa fa-fw fa-save"></i> No, save as new record</button>[% ELSE %]<button type="submit" class="new" onclick="confirmnotdup('view'); return false;"><i class="fa fa-fw fa-save"></i> No, save as new record</button>[% END %]
>                         </form>
>                     </div>
>         [% END %]
>-- 
>2.7.0

Actions: View | Diff | Splinter Review

Attachments on bug 16059: 49094 | 49233 | 49243