Attachment 49246 Details for Bug 16071 – Bug 16071: Use Font Awesome icons in authority duplicate warning dialog

[patch] Bug 16071: Use Font Awesome icons in authority duplicate warning dialog

Bug-16071-Use-Font-Awesome-icons-in-authority-dupl.patch (text/plain), 3.11 KB, created by Jonathan Druart on 2016-03-17 09:08:41 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2016-03-17 09:08:41 UTC

Size: 3.11 KB

patch

obsolete

>From eada7a25eeb1b1e6697d5ac15f90c18bfbe0dbfa Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Mon, 14 Mar 2016 13:47:01 -0400
>Subject: [PATCH] Bug 16071: Use Font Awesome icons in authority duplicate
> warning dialog
>
>In the authority editor, when a duplicate record is suspected a
>dialog is shown. This patch updates the template to show Font Awesome
>icons in this dialog.
>
>Also changed: Using <h3> instead of <h4> in dialog so that it is
>correctly styled. Adding "popup" class to duplicate record link to
>indicate that a new window will be opened.
>
>To test, apply the patch and go to Authorities -> New record.
>
>- Use Z39.50 to import a record which is already in your catalog.
>- Save the record. Confirm that the duplicate warning dialog is styled
>  correctly.
>- Confirm that both the "Save as new" and "Edit existing" buttons work
>  correctly.
>
>Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
>Works as advertised
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> .../intranet-tmpl/prog/en/modules/authorities/authorities.tt      | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt
>index 7faf688..d8501a3 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt
>@@ -181,15 +181,15 @@ function confirmnotdup(redirect){
> 
> [% IF ( duplicateauthid ) %]
>         <div class="dialog alert">
>-                <h4>Duplicate record suspected</h4>
>-                <p>Is this a duplicate of <a href="/cgi-bin/koha/authorities/detail.pl?authid=[% duplicateauthid %]" onclick="openWindow('/cgi-bin/koha/authorities/detail.pl?authid=[% duplicateauthid %]&amp;popup=1', 'DuplicateAuthority','800','600'); return false;" class="button">[% duplicateauthvalue %]</a>?</p>
>+                <h3>Duplicate record suspected</h3>
>+                <p>Is this a duplicate of <a href="/cgi-bin/koha/authorities/detail.pl?authid=[% duplicateauthid %]" class="popup" onclick="openWindow('/cgi-bin/koha/authorities/detail.pl?authid=[% duplicateauthid %]&amp;popup=1', 'DuplicateAuthority','800','600'); return false;" class="button">[% duplicateauthvalue %]</a> ?</p>
> 
>                 <form action="authorities.pl" method="get">
>                     <input type="hidden" name="authid" value="[% duplicateauthid %]" />
>-                    <input type="submit" class="edit" value="Yes: Edit existing authority" />
>+                    <button type="submit" class="new"><i class="fa fa-pencil"></i> Yes: Edit existing authority</button>
>                 </form>
>                 <form action="authorities.pl" method="get">
>-                    <input type="button" value="No: Save as new authority" class="save" accesskey="w" onclick="confirmnotdup('items'); return false;" />
>+                    <button class="new" onclick="confirmnotdup('items'); return false;"><i class="fa fa-save"></i> No: Save as new authority</button>
>                 </form>
>         </div>
> [% END %]
>-- 
>2.7.0

Actions: View | Diff | Splinter Review

Attachments on bug 16071: 49133 | 49230 | 49246