Bugzilla – Attachment 49255 Details for
Bug 15745
C4::Matcher gets CCL parsing error if term contains ? (question mark)
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 15745 - C4::Matcher gets CCL parsing error if term contains ? (question mark)
Bug-15745---C4Matcher-gets-CCL-parsing-error-if-te.patch (text/plain), 1.51 KB, created by
Olli-Antti Kivilahti
on 2016-03-17 12:26:05 UTC
(
hide
)
Description:
Bug 15745 - C4::Matcher gets CCL parsing error if term contains ? (question mark)
Filename:
MIME Type:
Creator:
Olli-Antti Kivilahti
Created:
2016-03-17 12:26:05 UTC
Size:
1.51 KB
patch
obsolete
>From 7eb5ccc5acb4d22a8e5a250236f8f4be779cd05e Mon Sep 17 00:00:00 2001 >From: David Cook <dcook@prosentient.com.au> >Date: Fri, 5 Feb 2016 16:09:45 +1100 >Subject: [PATCH] Bug 15745 - C4::Matcher gets CCL parsing error if term > contains ? (question mark) > >Signed-off-by: Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> > >Also fixes ! and + >Rebased to master >--- > C4/Matcher.pm | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > >diff --git a/C4/Matcher.pm b/C4/Matcher.pm >index 0dd8782..a59ba67 100644 >--- a/C4/Matcher.pm >+++ b/C4/Matcher.pm >@@ -656,7 +656,8 @@ sub get_matches { > else { > my $phr = C4::Context->preference('AggressiveMatchOnISBN') ? ',phr' : q{}; > $query = join( " or ", >- map { "$matchpoint->{'index'}$phr=$_" } @source_keys ); >+ map { "$matchpoint->{'index'}$phr=\"$_\"" } @source_keys ); >+ #NOTE: double-quote the values so you don't get a "Embedded truncation not supported" error when a term has a ? in it. > } > > require C4::Search; >@@ -812,7 +813,7 @@ sub _get_match_keys { > } else { > foreach my $subfield ($field->subfields()) { > if (exists $component->{'subfields'}->{$subfield->[0]}) { >- $string .= " " . $subfield->[1]; >+ $string .= " " . $subfield->[1]; #FIXME: It would be better to create an array and join with a space later... > } > } > } >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 15745
:
47676
|
49255
|
49809