Attachment 49273 Details for Bug 16073 – Bug 16073: Fix software error in circulation.pl

[patch] Bug 16073: Fix software error in circulation.pl

Bug-16073-Fix-software-error-in-circulationpl.patch (text/plain), 1.69 KB, created by Tomás Cohen Arazi (tcohen) on 2016-03-17 15:14:13 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2016-03-17 15:14:13 UTC

Size: 1.69 KB

patch

obsolete

>From 0face08e320ffc7391317dd66484a88fc456470c Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Mon, 14 Mar 2016 18:41:02 +0000
>Subject: [PATCH] Bug 16073: Fix software error in circulation.pl
>
>Can't call method "guarantor" on an undefined value at
>/home/koha/src/circ/circulation.pl line 588.
> at /home/koha/src/circ/circulation.pl line 673
>
>Introduced by bug 15656
>
>Test plan:
>Just trigger circ/circulation.pl
>
>Signed-off-by: Jacek Ablewicz <abl@biblos.pk.edu.pl>
>Triggered circ/circulation.pl - nothing exploded, and error is gone
>Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar>
>---
> circ/circulation.pl | 14 ++++++++------
> 1 file changed, 8 insertions(+), 6 deletions(-)
>
>diff --git a/circ/circulation.pl b/circ/circulation.pl
>index 924db65..74a7524 100755
>--- a/circ/circulation.pl
>+++ b/circ/circulation.pl
>@@ -583,13 +583,15 @@ my $view = $batch
>     ?'batch_checkout_view'
>     : 'circview';
> 
>-my $patron = Koha::Patrons->find( $borrower->{borrowernumber} );
> my @relatives;
>-if ( my $guarantor = $patron->guarantor ) {
>-    push @relatives, $guarantor->borrowernumber;
>-    push @relatives, $_->borrowernumber for $patron->siblings;
>-} else {
>-    push @relatives, $_->borrowernumber for $patron->guarantees;
>+if ( $borrowernumber ) {
>+    my $patron = Koha::Patrons->find( $borrower->{borrowernumber} );
>+    if ( my $guarantor = $patron->guarantor ) {
>+        push @relatives, $guarantor->borrowernumber;
>+        push @relatives, $_->borrowernumber for $patron->siblings;
>+    } else {
>+        push @relatives, $_->borrowernumber for $patron->guarantees;
>+    }
> }
> my $relatives_issues_count =
>   Koha::Database->new()->schema()->resultset('Issue')
>-- 
>2.7.3

Actions: View | Diff | Splinter Review

Attachments on bug 16073: 49147 | 49163 | 49203 | 49273 | 49274