Attachment 49314 Details for Bug 16104 – Bug 16104: Remove warnings "used only once: possible typo"

[patch] Bug 16104: Remove warnings "used only once: possible typo"

Bug-16104-Remove-warnings-used-only-once-possible-.patch (text/plain), 1.39 KB, created by Jonathan Druart on 2016-03-18 13:34:50 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2016-03-18 13:34:50 UTC

Size: 1.39 KB

patch

obsolete

>From 837f31dced25359d51a697f86627b0d7d5b35a64 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Fri, 18 Mar 2016 13:31:27 +0000
>Subject: [PATCH] Bug 16104: Remove warnings "used only once: possible typo"
>
>Since bug 11998, the following warnings are raised:
>Name "Tie::Hash::FIELDS" used only once: possible typo at /usr/share/perl/5.22/fields.pm line 135.
>Name "Cache::RemovalStrategy::LRU::FIELDS" used only once: possible typo at /usr/share/perl/5.22/fields.pm line 135.
>Name "Cache::RemovalStrategy::FIELDS" used only once: possible typo at /usr/share/perl/5.22/fields.pm line 135.
>
>It comes from the Koha::Cache
>
>103     if ( can_load( modules => { 'Cache::Memory' => undef } ) ) {
>
>Test plan:
>  perl -wc C4/AuthoritiesMarc.pm
>should return green
>
>QA note: this may have an impact on performance but I have not found any other workarounds.
>---
> Koha/Cache.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/Koha/Cache.pm b/Koha/Cache.pm
>index 9856e80..e352624 100644
>--- a/Koha/Cache.pm
>+++ b/Koha/Cache.pm
>@@ -100,7 +100,7 @@ sub new {
>         }
>     }
> 
>-    if ( can_load( modules => { 'Cache::Memory' => undef } ) ) {
>+    if ( can_load( modules => { 'Cache::Memory' => undef, nocache => 1 } ) ) {
>         _initialize_memory($self);
>         if ( $self->{'default_type'} eq 'memory'
>             && defined( $self->{'memory_cache'} ) )
>-- 
>2.7.0

Actions: View | Diff | Splinter Review

Attachments on bug 16104: 49314 | 49325 | 49827 | 51087 | 51088